Skip to content

chore: use Init command and service from upstream #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

chore: use Init command and service from upstream #761

merged 1 commit into from
Nov 28, 2024

Conversation

@tigarmo
Copy link
Collaborator

@tigarmo tigarmo commented Nov 25, 2024

  • Have you signed the CLA?

@tigarmo tigarmo force-pushed the work/CRAFT-3693-upstream-init branch 3 times, most recently from 8dc2381 to d14c5dd Compare November 25, 2024 18:54
@dariuszd21 dariuszd21 mentioned this pull request Nov 25, 2024
Closed
1 task
@tigarmo tigarmo force-pushed the work/CRAFT-3693-upstream-init branch from d14c5dd to 3434a9d Compare November 26, 2024 13:27
@tigarmo tigarmo closed this Nov 26, 2024
@tigarmo tigarmo reopened this Nov 26, 2024
@tigarmo tigarmo force-pushed the work/CRAFT-3693-upstream-init branch from 3434a9d to 0e2f904 Compare November 26, 2024 14:10
@tigarmo tigarmo marked this pull request as ready for review November 26, 2024 15:57
@tigarmo tigarmo changed the title Work/craft 3693 upstream init chore: use Init command and service from upstream Nov 26, 2024
@tigarmo tigarmo force-pushed the work/CRAFT-3693-upstream-init branch 2 times, most recently from d8e0514 to 5b46352 Compare November 27, 2024 14:05
@tigarmo tigarmo requested review from dariuszd21 and mr-cal November 27, 2024 15:42
dariuszd21
dariuszd21 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

dariuszd21

This comment was marked as duplicate.

Sign in to view

mr-cal
mr-cal approved these changes Nov 27, 2024
View reviewed changes
@mr-cal
Copy link
Contributor

mr-cal commented Nov 27, 2024

I think refactor may be more precise than chore as the commit category.

@tigarmo
feat: use Init command and service from upstream
e07e673 
This is *almost* a chore, as the templates, supported profiles, etc are all
unchanged. However, the upstream command adds support for the "--project-dir"
argument, so this is ends up being a feature.

Fixes #753
@tigarmo tigarmo force-pushed the work/CRAFT-3693-upstream-init branch from 5b46352 to e07e673 Compare November 28, 2024 17:14
@tigarmo tigarmo added the rebase label Nov 28, 2024
@tigarmo tigarmo merged commit 484099f into main Nov 28, 2024
14 of 15 checks passed
@tigarmo tigarmo deleted the work/CRAFT-3693-upstream-init branch November 28, 2024 18:26
@tigarmo
Copy link
Collaborator Author

tigarmo commented Nov 28, 2024

I think refactor may be more precise than chore as the commit category.

In the end I updated the commit to feat as there is new functionality (the --project-dir argument)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dariuszd21 dariuszd21 dariuszd21 approved these changes

@mr-cal mr-cal mr-cal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tigarmo @mr-cal @dariuszd21