feat: add uv plugin #792
Merged
feat: add uv plugin #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3022c8 to
ff0e5fa
Compare
|
Test failures should all be unrelated:
|
tigarmo
reviewed
Jan 28, 2025
tigarmo
requested changes
Jan 28, 2025
There was a problem hiding this comment.
The docs failure is related:
checking consistency... /home/docs/checkouts/readthedocs.org/user_builds/canonical-rockcraft/checkouts/792/docs/common/craft-parts/reference/plugins/go_use_plugin.rst: WARNING: document isn't included in any toctree
/home/docs/checkouts/readthedocs.org/user_builds/canonical-rockcraft/checkouts/792/docs/common/craft-parts/reference/plugins/uv_plugin.rst: WARNING: document isn't included in any toctree
|
@lengau do you know what's up with this OSV-scanner? I don't know which requirements file it's picking up here: |
|
I think the failure is coming from this being unpinned: https://github.com/canonical/rockcraft/blob/main/docs/tutorial/code/fastapi/requirements.txt |
lengau
reviewed
Jan 28, 2025
lengau
approved these changes
Jan 28, 2025
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
medubelko
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the uv plugin from craft-parts to Rockcraft.
CRAFT-3916
Closes #789.