Skip to content

Conversation

@jahn-junior
Copy link
Contributor

  • Have you signed the CLA?

Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jahn-junior Great work! I've left some suggestions with my reasoning. Some changes are blocking, while others are more food for thought. Let me know what you think!

Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tigarmo tigarmo merged commit a07a6e6 into main Jan 31, 2025
13 of 15 checks passed
@tigarmo tigarmo deleted the work/remote-build-how-to/DOCPR-1314 branch January 31, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants