Skip to content

Conversation

@yanksyoon
Copy link
Member

  • Have you signed the CLA?

Fixes issues with using hardcoded Python 3.10 for gunicorn based extensions. As we add support for more bases, different python versions for different bases should be added accordingly.

@yanksyoon yanksyoon requested a review from jdkandersson March 20, 2025 12:31
Copy link
Contributor

@jdkandersson jdkandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine after you implement the feedback from Tiago

@gregory-schiano
Copy link
Contributor

Can we get that PR also landed on feature/pro-sources branch too ? I'll need it for a demo along with pro feature

@tigarmo
Copy link
Collaborator

tigarmo commented Mar 21, 2025

Can we get that PR also landed on feature/pro-sources branch too ? I'll need it for a demo along with pro feature

If someone creates the PR I'll merge it

@tigarmo tigarmo requested a review from a team March 21, 2025 11:21
@tigarmo tigarmo merged commit 31d3ab0 into canonical:main Mar 21, 2025
17 of 18 checks passed
yanksyoon added a commit to yanksyoon/rockcraft that referenced this pull request Mar 25, 2025
* fix: bare base gunicorn based extensions

* chore: raise notimplemented error for unknown base

* chore: scenario cleanup
yanksyoon added a commit to yanksyoon/rockcraft that referenced this pull request Mar 25, 2025
* fix: bare base gunicorn based extensions

* chore: raise notimplemented error for unknown base

* chore: scenario cleanup
tigarmo pushed a commit that referenced this pull request Mar 25, 2025
* fix: bare base gunicorn based extensions

* chore: raise notimplemented error for unknown base

* chore: scenario cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants