Skip to content

feat: add org.opencontainers.image.description to rocks #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2025
Merged

feat: add org.opencontainers.image.description to rocks #841

merged 3 commits into from
Mar 21, 2025

Conversation

@alesancor1
Copy link
Member

@alesancor1 alesancor1 commented Mar 20, 2025 •
edited
Loading

  • Have you signed the CLA?

Added org.opencontainers.image.description OCI annotation to all rocks. This annotation uses a combination of summary + description fields from rockcraft.yaml file, following this format:

<summary>

<description>

The annotation is addded to the Config.Labels field in Docker.

Example for the hello-world rock:

Input:
docker image inspect hello:latest | jq -r .[0].Config.Labels

Output:
image

tigarmo
tigarmo approved these changes Mar 21, 2025
View reviewed changes
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks!

@tigarmo tigarmo requested a review from cjdcordeiro March 21, 2025 11:41
@tigarmo tigarmo added the squash label Mar 21, 2025
cjdcordeiro
cjdcordeiro approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice LGTM

@tigarmo tigarmo merged commit cdda937 into canonical:main Mar 21, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tigarmo tigarmo tigarmo approved these changes

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alesancor1 @tigarmo @cjdcordeiro