[WIP] feat: spring boot extension #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigarmo
reviewed
Apr 22, 2025
tigarmo
reviewed
Apr 22, 2025
|
@yanksyoon can you merge in |
|
Related spread failure: |
vpa1977
suggested changes
Apr 29, 2025
This reverts commit 4e92200.
tigarmo
requested changes
May 7, 2025
rockcraft/extensions/springboot.py
Outdated
| ] | ||
| override_build_cmds += [ | ||
| "cp ${CRAFT_STAGE}/*init.gradle* ${CRAFT_PART_BUILD}/.gradle/", | ||
| "rm -f ${CRAFT_STAGE}/*init.gradle*", |
There was a problem hiding this comment.
@vpa1977 is right; if the intent is that the gradle-init-script part will provide an init-script that is available during the other part's build but not primed then that part should have its own prime: key (we can document this).
As it is this override-build snippet is wrong: a build script must not remove files from stage/prime.
|
|
||
| build_packages = [*self.DEFAULT_BUILD_PACKAGES] | ||
| if not self.gradlew_path.exists(): | ||
| build_packages += ["gradle"] |
There was a problem hiding this comment.
Yes I believe our extensions should default to using archive things. We can discuss how to 'detect' user-provided gradle declarations in the future as an improvement.
Well, there are many related spread failures. This one happened multiple times: |
medubelko
approved these changes
May 7, 2025
| Project requirements | ||
| ==================== | ||
|
|
||
| To use the ``spring-boot-framework`` extension, there must be either: |
There was a problem hiding this comment.
spring-boot-framework
Except for when we're referring to its name in code, let's please use the plain English name of the extension. :)
Comment on lines
32
to
33
| The ``spring-boot-framework`` extension dynamically determines the plugin to be | ||
| used to bulid the rock. Depending on the presence of ``pom.xml`` or |
There was a problem hiding this comment.
Suggested change
| The ``spring-boot-framework`` extension dynamically determines the plugin to be | |
| used to bulid the rock. Depending on the presence of ``pom.xml`` or | |
| The ``spring-boot-framework`` extension dynamically determines the plugin to use | |
| use to bulid the rock. Depending on the presence of ``pom.xml`` or |
| or `gradle | ||
| <https://documentation.ubuntu.com/rockcraft/en/latest/common/craft-parts/ | ||
| reference/plugins/gradle_plugin/>`_ | ||
| plugin respectively. |
There was a problem hiding this comment.
Suggested change
| plugin respectively. | |
| plugin, respectively. |
Comment on lines
85
to
89
| To provide an efficient runtime for Java, the `Jlink | ||
| <https://documentation.ubuntu.com/rockcraft/en/latest/common/craft-parts/ | ||
| reference/plugins/jlink_plugin/>`_ | ||
| plugin is used to trim out any unused parts of the JDK. This reduces the size | ||
| of the rock and improves the performance. |
There was a problem hiding this comment.
Suggested change
| To provide an efficient runtime for Java, the `Jlink | |
| <https://documentation.ubuntu.com/rockcraft/en/latest/common/craft-parts/ | |
| reference/plugins/jlink_plugin/>`_ | |
| plugin is used to trim out any unused parts of the JDK. This reduces the size | |
| of the rock and improves the performance. | |
| To provide an efficient runtime for Java, the extension calls the `Jlink | |
| <https://documentation.ubuntu.com/rockcraft/en/latest/common/craft-parts/ | |
| reference/plugins/jlink_plugin/>`_ | |
| plugin to trim out any unused parts of the JDK. This reduces the size | |
| of the rock and improves performance. |
| parts: | ||
| spring-boot-framework/install-app: | ||
| build-packages: | ||
| - openjdk-17-jdk # specify the Java package to use |
There was a problem hiding this comment.
Suggested change
| - openjdk-17-jdk # specify the Java package to use | |
| - openjdk-17-jdk # specify the Java package to use |
Comment on lines
101
to
106
| - default-jdk | ||
| stage-packages: # these packages are required for bare base rocks. | ||
| - bash_bins | ||
| - ca-certificates_data | ||
| - coreutils_bins | ||
| - base-files_tmp |
There was a problem hiding this comment.
Suggested change
| - default-jdk | |
| stage-packages: # these packages are required for bare base rocks. | |
| - bash_bins | |
| - ca-certificates_data | |
| - coreutils_bins | |
| - base-files_tmp | |
| - default-jdk | |
| stage-packages: # these packages are required for bare base rocks. | |
| - bash_bins | |
| - ca-certificates_data | |
| - coreutils_bins | |
| - base-files_tmp |
|
@yanksyoon in addition to the unit test failures, here are the spread errors that I can see: |
|
Still this one left: |
tigarmo
approved these changes
May 18, 2025
|
@medubelko @yanksyoon I merged with some open comments/suggestions from Michael so we can finally get this feature in; we should do a smaller follow-up PR addressing the open comments. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint && make test?Currently blocked by: