-
Notifications
You must be signed in to change notification settings - Fork 60
docs: Incorporate UX feedback into 12-factor tutorials #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions and one correction. The changes should cascade to all tutorials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
|
@tigarmo Are the tests simply timing out? |
|
Hi @tigarmo and @medubelko , I double checked just now and my email is already associated with the Canonical CLA. Let me know if there's anything I need to do on my end to get the workflow to pass. |
make lint && make test?I ran
make lintand received errors on files this PR doesn't touch.Updates to the tutorials based on feedback in UX sessions:
0.1-chisel, resulting in a error.In addition, two corrections to the Express and Spring Boot tutorials:
mkdir <app rock name>andcd <app rock name>to the beginning of the tutorial so that the rock will have the correct name from the start.