Skip to content

Conversation

@erinecon
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint && make test?

I ran make lint and received errors on files this PR doesn't touch.


Updates to the tutorials based on feedback in UX sessions:

  1. When copying the skopeo command for the chiseled hello world rock. The user missed the hint to change the name in the project file to 0.1-chisel, resulting in a error.
  2. File headers could be added to file excerpts (app.py) External example
  3. Clarification may be needed on what the skopeo command is doing. Maybe we could also mention about how Docker requires rocks (or images in general) to be imported into the daemon since they cannot be executed directly like an executable.

In addition, two corrections to the Express and Spring Boot tutorials:

  1. Add mkdir <app rock name> and cd <app rock name> to the beginning of the tutorial so that the rock will have the correct name from the start.
  2. Update the port to the correct value.

@erinecon erinecon changed the title 12f tutorials ux feedback docs: Incorporate UX feedback into 12-factor tutorials May 30, 2025
Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions and one correction. The changes should cascade to all tutorials.

@erinecon erinecon requested a review from medubelko June 10, 2025 12:28
Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@medubelko
Copy link
Contributor

@tigarmo Are the tests simply timing out?

@medubelko
Copy link
Contributor

@erinecon The failures aren't related to your branch. We're rerunning the tests. If they pass, @tigarmo will merge today, but if not he'll work on a fix and have it merged by tomorrow morning.

@erinecon
Copy link
Contributor Author

Hi @tigarmo and @medubelko , I double checked just now and my email is already associated with the Canonical CLA. Let me know if there's anything I need to do on my end to get the workflow to pass.

@tigarmo tigarmo merged commit 9a40a4a into canonical:main Jun 11, 2025
32 of 37 checks passed
@erinecon erinecon deleted the 12f-tutorials-ux-feedback branch July 11, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants