-
Notifications
You must be signed in to change notification settings - Fork 60
docs: Incorporate UX feedback into 12-factor tutorials #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left some smallish suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. Waiting on a possible fix for last two intertwined comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erinecon Those fixes LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! I'll merge these once the tests finish
Incorporate feedback from UX sessions into the 12-factor tutorials.
Summary of changes
npmandgoinstances, converted some of the profile mentions to plain text, updated the Spring Boot tutorial title in the navigational menu)make lint && make test?Successfully ran
make lint-docs