ci: clean up OSV workflows #927
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upils
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
LGTM.
Note: Looking at the logs, it seems that osv is still looking at requirements-noble.txt (see https://github.com/canonical/rockcraft/actions/runs/16480559838/job/46593493067?pr=927#step:6:11).
Also it appears we could maybe make the scanning faster (it is not really slow so that is a nitpick) by also excluding both tools/external and docs/sphinx-starter-pack submodules.
|
Interesting, it looks like this might've never worked because I can see it being scanned in Snapcraft as well: https://github.com/canonical/snapcraft/actions/runs/16484509318/job/46606446340#step:6:11 Looking at the workflow files though, I can't really tell why it wouldn't work. At least it isn't broken anymore, I guess? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint && make test?Fixes up the OSV scanner workflows moving forward by using the same arguments Snapcraft and Charmcraft use and removing a now-outdated config.