Skip to content

Conversation

@alesancor1
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint && make test?

This PR adds the entrypoint-command field to the rockcraft.yaml to replace the default pebble enter entrypoint when set. Tests and docs have been added accordingly.

@alesancor1 alesancor1 requested a review from cjdcordeiro August 22, 2025 18:42
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I like the overall approach but I think we can clean the code up a bit

@alesancor1 alesancor1 requested a review from tigarmo August 26, 2025 08:39
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Thank you

Copy link
Contributor

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI errors seem unrelated to me, so LGTM. Thanks for the changes

Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com>
Signed-off-by: Alejandro Santisteban <alex.santisteban@canonical.com>
@tigarmo tigarmo merged commit 0f919f9 into canonical:main Aug 28, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants