-
Notifications
You must be signed in to change notification settings - Fork 60
feat: add entrypoint-command #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add entrypoint-command #939
Conversation
args are now being parsed and validated following the same logic from pebble.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! I like the overall approach but I think we can clean the code up a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI errors seem unrelated to me, so LGTM. Thanks for the changes
Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com> Signed-off-by: Alejandro Santisteban <alex.santisteban@canonical.com>
make lint && make test?This PR adds the
entrypoint-commandfield to the rockcraft.yaml to replace the defaultpebble enterentrypoint when set. Tests and docs have been added accordingly.