Skip to content

docs: cover interim bases #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2025
Merged

docs: cover interim bases #971

merged 3 commits into from
Sep 25, 2025

Conversation

@medubelko
Copy link
Contributor

@medubelko medubelko commented Sep 17, 2025

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint && make test?

@medubelko medubelko requested a review from tigarmo as a code owner September 17, 2025 22:58
medubelko
medubelko commented Sep 17, 2025
View reviewed changes
lengau
lengau reviewed Sep 18, 2025
View reviewed changes
lengau
lengau reviewed Sep 18, 2025
View reviewed changes
lengau
lengau reviewed Sep 18, 2025
View reviewed changes
lengau
lengau reviewed Sep 18, 2025
View reviewed changes
lengau
lengau reviewed Sep 18, 2025
View reviewed changes
lengau
lengau reviewed Sep 18, 2025
View reviewed changes
@medubelko medubelko requested a review from lengau September 19, 2025 00:55
tigarmo
tigarmo approved these changes Sep 19, 2025
View reviewed changes
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good!

lengau
lengau approved these changes Sep 19, 2025
View reviewed changes
Copy link
Collaborator

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jahn-junior
jahn-junior reviewed Sep 22, 2025
View reviewed changes
jahn-junior
jahn-junior approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@jahn-junior jahn-junior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@medubelko medubelko force-pushed the rockcraft-243-docs-interim-bases branch from ddd09ff to db9d4a3 Compare September 23, 2025 23:58
@tigarmo tigarmo merged commit 8c1b49d into canonical:main Sep 25, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tigarmo tigarmo tigarmo approved these changes

@lengau lengau lengau approved these changes

@jahn-junior jahn-junior jahn-junior approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@medubelko @tigarmo @lengau @jahn-junior @juju-charm-bot