project: use pebble snap instead of building #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4b5275 to
c17cef9
Compare
|
The spread failure is due to this bug: https://bugs.launchpad.net/snapd/+bug/2002835 |
lengau
approved these changes
Jan 17, 2023
cjdcordeiro
requested changes
Jan 18, 2023
Now that pebble has been published as a snap we can use it directly instead of building the binary each time. Prime only the binary and "organize" it as /usr/bin/pebble just like the previous part did.
5932a05 to
26ff522
Compare
|
Out of curiosity, what is the speed improvement here? |
|
@sergiusens I compared the spread runs with and without this change and it looks like we went from around ~32min to around ~26min (total). Pretty nice actually |
tigarmo
pushed a commit
that referenced
this pull request
Mar 24, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that pebble has been published as a snap we can use it directly instead of building the binary each time. Prime only the binary and "organize" it as /usr/bin/pebble just like the previous part did.
(CRAFT-1566)