Skip to content

docs: create separate chisel documentation #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2023
Merged

docs: create separate chisel documentation #269

merged 2 commits into from
May 19, 2023

Conversation

@dboddie
Copy link
Contributor

@dboddie dboddie commented May 19, 2023

  • Have you signed the CLA?

@dboddie dboddie force-pushed the split-chisel-docs branch from 54c0c0e to 19265f0 Compare May 19, 2023 13:29
sergiusens
sergiusens approved these changes May 19, 2023
View reviewed changes
Copy link

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't deserve to be a draft anymore :-)

@dboddie dboddie marked this pull request as ready for review May 19, 2023 14:14
@dboddie dboddie requested a review from cjdcordeiro May 19, 2023 14:15
cjdcordeiro
cjdcordeiro approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

I'm approving, although there's a small hiccup:

  • the _static assets are being included via their absolute path in the server, which means they won't render in GitHub. Is there a strong reason not to use relative paths instead?

@dboddie
Copy link
Contributor Author

dboddie commented May 19, 2023 

* the _static assets are being included via their absolute path in the server, which means they won't render in GitHub. Is there a strong reason not to use relative paths instead?

I'll change them to be relative.

cjdcordeiro
cjdcordeiro approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks

@dboddie dboddie merged commit 6b988c8 into canonical:main May 19, 2023
@dboddie dboddie deleted the split-chisel-docs branch May 19, 2023 19:29
tigarmo pushed a commit that referenced this pull request Mar 24, 2025
@renovate
build(deps): update pre-commit hook astral-sh/ruff-pre-commit to v0.6…
84c2a0e 
….9 (#269)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

+1 more reviewer

@sergiusens sergiusens sergiusens approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dboddie @sergiusens @cjdcordeiro