Gzip config #2360
Open
Gzip config #2360
+66
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
githubsaturn
left a comment
There was a problem hiding this comment.
Thanks! Just two nit suggestions. For the CaptainConstant, let's use default prefix. For the server, let's drop the prefix.
This will allow us, in the future, to have a clean override at the app level. i.e. something like:
serverWithSubDomain.gzipOn =
app.gzipOn ?? CaptainConstants.configs.defaultGzipOn
This is just in case there are some cases where this needs to be adjusted at the app level. If that happens, we'll add these configs at the app level and will expose that in the UI.
|
|
||
| defaultGzipOn: true, | ||
|
|
||
| gzipTypes: |
Collaborator
There was a problem hiding this comment.
Let's change to defaultGzipTypes
| staticWebRoot: string | ||
| redirectToPath?: string | ||
| logAccessPath?: string | ||
| defaultGzipOn?: boolean |
Collaborator
There was a problem hiding this comment.
Let's change to gzipOn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Gzip compression by default for all apps
#2259