Skip to content

Conversation

@sorcio
Copy link
Contributor

@sorcio sorcio commented Oct 9, 2025

Fixes #408

@sorcio
Copy link
Contributor Author

sorcio commented Oct 15, 2025

Unfortunately, checking CARGO_CFG_TARGET_OS at runtime means that we always have to compile all branches of the build.rs script. This means that we always need to depend on pkg-config even in pure Rust builds. It might be annoying to add a build dependency when most setups probably will never need it.

@cberner if this is acceptable I will leave it like this. Otherwise I can look into some darker magic, because I can't think of an easy solution.

@cberner
Copy link
Owner

cberner commented Oct 16, 2025

That sounds fine

@sorcio
Copy link
Contributor Author

sorcio commented Oct 16, 2025

If CI passes then I think this is good :)

@cberner cberner merged commit 6d4725e into cberner:master Oct 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build.rs doesn't work with cross-compilation

2 participants