feat: add optional blocking parameter and unmount mode overrides #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix issue #411 by adding a method called
set_blocking_umountonSession,SessionUnmounterandBackgroundSession.In all 3 variants of the
Mountstructure, ifblocking_umountis active, the mount will try to unmount normally, but if it encoutersEBUSY(ResourceBusy) due to open handles, it will wait for 0.5 seconds before retrying.The unmounting behavior is also made more uniform - the new behavior is that instead of unpredictable unmount modes happening when
EACCESis returned, no unmount flags are added. This behavior should be able to be overridden usingset_unmount_optionson session objects.