fsearch_window.c get_sort_type_for_name: Add nullptr check #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cboxdoerfer
reviewed
Feb 27, 2022
src/fsearch_window.c
Outdated
| get_sort_type_for_name(const char *name) { | ||
| if (!name) { | ||
| g_warning("[get_sort_type_for_name] name is nullptr"); | ||
| return 0; |
Owner
There was a problem hiding this comment.
Even though the effect is exactly the same, I think it's a better idea to return DATABASE_INDEX_TYPE_NAME instead of 0. It's a little more descriptive, because it's considered the default sorting type.
… on nullptr parameter
Owner
|
Thank you, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running this on my Debian 11 installation, the param
nameinget_sort_type_for_namewould be null on startup. I assume returning 0 might cause issues, but the program worked flawlessly after adding this check.