Skip to content

Recovered publications histogram, has_recovered_publications label #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 18, 2025
Merged

Recovered publications histogram, has_recovered_publications label #496

merged 5 commits into from
Jul 18, 2025

Conversation

@FZambia
Copy link
Member

@FZambia FZambia commented Jul 17, 2025 •
edited
Loading

A couple of Prometheus metrics improvements to help with questions like in centrifugal/centrifuge-js#325

  1. Add has_recovered_publications="yes/no" label to recover counter. If at least one publication was recovered by a client – the label is yes, otherwise (no publications, but still recovery may be successful!) – no.
  2. Add recovered publications histogram to track distribution of number of publications in successful recovery. By default, this s disabled and should be enabled over Config.Metrics.EnableRecoveredPublicationsHistogram

@codecov
Copy link

codecov bot commented Jul 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.63%. Comparing base (48b846c) to head (45988a4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
client.go 76.47% 4 Missing ⚠️
metrics.go 90.90% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
+ Coverage   83.50%   83.63%   +0.13%     
==========================================
  Files          39       39              
  Lines        9069     9106      +37     
==========================================
+ Hits         7573     7616      +43     
+ Misses       1133     1130       -3     
+ Partials      363      360       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FZambia FZambia changed the title Recovered publications histogram, had_recovered_publications label Recovered publications histogram, has_recovered_publications label Jul 18, 2025
@FZambia FZambia merged commit b39d7ee into master Jul 18, 2025
8 checks passed
@FZambia FZambia deleted the more_recovery_metrics branch July 19, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FZambia