Skip to content

Conversation

@Muhammad-Rebaal
Copy link
Contributor

Hey @ManofWax !
You can merge the PR as I've removed conflicts in the issue #149
Thank You !

@Lorygold Lorygold changed the title Removed the Conflicts Slack Alerter Mar 6, 2025
@Lorygold
Copy link
Collaborator

Lorygold commented Mar 6, 2025

Hi @Muhammad-Rebaal, some notes:

  1. for next times... it wasn't necessary to close the old PR, you could have made just the commit with the conflicts removal, also because the name of this PR is not correct, since it is relative to the "slack alert feature" (and not just to the "Removed the conflicts").
    Anyway, I have changed the name of the PR;
  2. as you can see from the CI, the black linter returned an error, so please run it locally and fix it, as specified in the CONTRIBUTING file

Thank you!

@Lorygold Lorygold requested a review from ManofWax March 6, 2025 17:06
@Muhammad-Rebaal
Copy link
Contributor Author

Hi @Muhammad-Rebaal, some notes:

  1. for next times... it wasn't necessary to close the old PR, you could have made just the commit with the conflicts removal, also because the name of this PR is not correct, since it is relative to the "slack alert feature" (and not just to the "Removed the conflicts").
    Anyway, I have changed the name of the PR;
  2. as you can see from the CI, the black linter returned an error, so please run it locally and fix it, as specified in the CONTRIBUTING file

Thank you!

Hi @Lorygold @ManofWax !
Yeah sure, I'd keep in mind that for the next time and I've resolved the issues in the code that are failing the checks so could you review that .
Thank You !

@ManofWax ManofWax merged commit 97dcf1b into certego:develop Mar 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants