Skip to content

Fix Pytest using the wrong Python installation, add Pyright to legacy Python workflow, fix syntax errors on Python 3.5, remove Pyflakes #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
craigcomstock merged 10 commits into from
Sep 3, 2025
Merged

Fix Pytest using the wrong Python installation, add Pyright to legacy Python workflow, fix syntax errors on Python 3.5, remove Pyflakes #279

craigcomstock merged 10 commits into from
Sep 3, 2025

Conversation

@jakub-nt
Copy link
Contributor

@jakub-nt jakub-nt commented Sep 2, 2025 •
edited
Loading

Turns out that during legacy Python test workflows, Pytest did not use the virtual environment's legacy Python version:

Run pytest
============================= test session starts ==============================
platform linux -- Python 3.12.3, pytest-8.4.1, pluggy-1.6.0
{...}

@jakub-nt
GHA workflow now calls Python tooling within the virtual environment
6ba7157 
pytest did not use the legacy Python version, instead using a local newer version

Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
@jakub-nt
Added Pyright and Pyflakes to legacy Python GHA workflow
984ff14 
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
@jakub-nt jakub-nt marked this pull request as draft September 2, 2025 14:04
@jakub-nt
Replaced Union[X, None] with Optional[X]
8759791 
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
@jakub-nt
Rewrote CFBSCommandGitResult for compatibility with Python 3.5
ab30006 
Ticket: ENT-13212
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
@jakub-nt
Fixed potential Mutable Default Argument bug
fdf40da 
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
@jakub-nt
Corrected incorrect type hint
9e17b59 
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
@jakub-nt
Rewrote CFBS args type hints for compatibility with Python 3.5
aece23f 
Ticket: ENT-13212
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
@jakub-nt jakub-nt force-pushed the pytest-legacy-python branch from c2e51c5 to aece23f Compare September 2, 2025 16:10
@jakub-nt
Ignore incorrect flake8 unused import error
75bb728 
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
@jakub-nt
Removed Pyflakes
2d59a7f 
It appears to be redundant when already using flake8, and it seems to be impossible to ignore an incorrect error it generates.

Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
@jakub-nt jakub-nt changed the title Fix Pytest using the wrong Python installation, add Pyright and Pyflakes to legacy Python workflow Fix Pytest using the wrong Python installation, add Pyright to legacy Python workflow, fix syntax errors on Python 3.5, remove Pyflakes Sep 2, 2025
@jakub-nt
Added type hints where Python 3.6's Pyright was getting confused
645e704 
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
@jakub-nt jakub-nt marked this pull request as ready for review September 2, 2025 17:03
larsewi
larsewi reviewed Sep 3, 2025
View reviewed changes
@craigcomstock craigcomstock merged commit a7f8bbc into cfengine:master Sep 3, 2025
11 checks passed
@craigcomstock craigcomstock mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsewi larsewi larsewi approved these changes

@olehermanse olehermanse Awaiting requested review from olehermanse

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakub-nt @larsewi @craigcomstock