Add subtitle keyword input for filtering subtitle tracks and Series Search. #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow an optional keyword to be supplied. This keyword needs to be present in either the title or displayTitle in order to be considered for matching. I made this change so I can easily make subtitles with "Forced" in the title be the only subtitles applied. This can be improved if there is a way to determine the forced flag instead of it needing to be in the name, but for my library this was sufficient and helpful.
Contributor
Author
|
I implemented this based off the idea in an Issue 53 comment: |
Contributor
Author
|
I also added a search for show since I was working on this code and saw this comment: |
cglatot
approved these changes
Sep 10, 2025
Owner
cglatot
left a comment
There was a problem hiding this comment.
Pretty good work!
2 comments to note for the subtitle keyword matching, though:
- The search box pushing down the subtitles table makes it look lopsided when side-by-side with the audio tracks table in in desktop. But I'm not sure how you would make this look nicer. Maybe a similar keyword search for audio as well? Less relevant, but might be some usecase for it, and would match styling.
- It's not very obvious that after you type in the keyword, you still need to select the track. I mean, I know it's not obvious even beforehand, but I find it counterintuitive. Might be worth updating the wording under the search box to say something.
Since these are enhancements, I've still approved and merged this, and opened #91
This was referenced Sep 10, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow an optional keyword to be supplied. This keyword needs to be present in either the title or displayTitle in order to be considered for matching.
I made this change so I can easily make subtitles with "Forced" in the title be the only subtitles applied. This can be improved if there is a way to determine the forced flag instead of it needing to be in the name, but for my library this was sufficient and helpful.
