setup-knative: Avoid GitHub API when possible #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unauthenticated API calls are 60/h: this action uses 8 calls. * The use of "git ls-remote" seems to end up at similar end result. * The existing sort call is changed from -n to -V: this is not required but is done to keep it in sync with the new sort call which does need the version sorting. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Merged
via the queue into
chainguard-dev:main
with commit Nov 20, 2025
c088192
12 of 14 checks passed
jku
added a commit
to jku/actions
that referenced
this pull request
Nov 20, 2025
REAL_KNATIVE_VERSION must be prefixed with "knative-v", PR chainguard-dev#656 broke that. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unauthenticated API calls are 60/h: this action uses 8 calls.
I've not tested this extensively but it seems right.
Fixes #655