Migrate to deck.gl - ready for review #1334
Conversation
There was a problem hiding this comment.
Copilot reviewed 74 out of 81 changed files in this pull request and generated no comments.
Files not reviewed (7)
- .env.docker: Language not supported
- .env.example: Language not supported
- locales/en/main.json: Language not supported
- locales/en/transit.json: Language not supported
- locales/fr/main.json: Language not supported
- locales/fr/transit.json: Language not supported
- packages/chaire-lib-frontend/package.json: Language not supported
Comments suppressed due to low confidence (1)
packages/chaire-lib-frontend/src/services/map/MapLayerManager.ts:68
- The variable 'enabledLayers' is used here but it is not defined in this scope. Please ensure that 'enabledLayers' is either passed as a parameter or defined before use.
this._enabledLayers = _uniq(enabledLayers).filter((layerName) => this._layersByName[layerName] !== undefined); // make sure we do not have the same layer twice (can happen with user prefs not replaced correctly after updates)
1d34cd4 to
e32b3b4
Compare
|
In the Deck gl instance (deckgldemo.transition.city), the outline of a path calculated in the routing path disappears when zooming too close. |
|
Bugs encore présents:
|
La layer stroke est généré automatiquement par Transition et est une simple PathLayer blanche utilisant les propriétés de la layer de base, mais avec 2 pixels de plus de largeur. On dirait qu'à un certain niveau de zoom intermédiaire, cette règle de 2 de plus de largeur ne fonctionne pas. @kaligrafy aurais-tu une idée si le shader fait qqc d'étrange à propos de la largeur? |
Je vais ajouter le stroke directement dans le shader, super simple |
98288ad to
672b079
Compare
|
Issues additionnels identifiés par @davidmurray et qu'il faudrait régler avant de
Aussi, j'ai observé cet issue:
|
|
Even though this dependency is not used, it causes compilation errors in chaire-lib-common when other packages, like carto, adds a dependency to a later version of `kdbush`
fixes #552, fixes #115 **Breaking changes** Remove dependencies to all mapbox packages Add dependencies to `deck.gl` 9.1.0 and other related packages. Rewrite all map event handlers, using `mjolnir.js`'s for event description. Update the layer descriptions to be non-mapbox dependent, with properly typed descriptors. Also simplify layer types, such that one does not need to explicitly define separate layers for filling and strokes, but a single layer description will generate proper layers at display time to correctly support the strokes. The polygon selection tool has been rewritten to support any selection instead of being tightly coupled with the node selection only. Also add support for a measure tool Co-authored-by: Geneviève Bastien <gbastien@versatic.net> Co-authored-by: Pierre-Léo Bourbonnais <leo.bourbonnais@polymtl.ca>
et ajout de path layer binaire
Enlever le layer raster au cas où Ajout de 2 layers geojson: une avec les mêmes paramètres que l'exemple, une autre avec nos paramètres de largeur
C'est identique à l'exemple, même avec les données!
No description provided.