Don't display any IPs when -privateserver is set. #1774
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is not correct, it will break the receiving end which expects the IP address. You need to send some kind of dummy value. |
Corrects a stupid mistake I used on a very old fork I made.
Author
|
oh right, I made a wrong copy/paste from my previous project which fully disabled it ; it showed IPs only for compatibility purposes with official releases of choco. Sorry ! |
turol
approved these changes
Nov 22, 2025
fabiangreffrath
requested changes
Nov 22, 2025
Member
fabiangreffrath
left a comment
There was a problem hiding this comment.
I'd like to suggest to initialize a variable with the result of the M_CheckParm("-privateserver") check, instead of checking it during each turn of the loop. And I'd like it to print a dummy like "hidden IP" instead of printing nothing at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been noticed that when hosting a privateserver (in case of livestreams), IP addresses are publicly displayed.
What was previously done was to only hide the IP of the host but not the client's IP, which is not acceptable.
This PR just simply does not show IPs only when hosting a privateserver. Fixes what issue #697 really is, on a very specific case.