Replace Invoke-WebRequest with .NET webclient to speed up downloads in Get-RemoteChecksum function #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current Get_RemoteChecksum implementation uses Invoke-WebRequest which can be slow on larger files. This results in a long checksumming process during automated packaging. By switching to the .NET webclient, while losing the "interactive" download update, we significantly increase the speed of the download. For example, on a 150 mb file, it went from minutes to download to seconds.
* 'develop' of github.com:chrrobi/chocolatey-au: Change the way the file is downloaded to speed it up
The current Get_RemoteChecksum implementation uses Invoke-WebRequest which can be slow on larger files. This results in a long checksumming process during automated packaging. By switching to the .NET webclient, while losing the "interactive" download update, we significantly increase the speed of the download. For example, on a 150 mb file, it went from minutes to download to seconds. Added modified date in this commit
The current Get_RemoteChecksum implementation uses Invoke-WebRequest with progress bar which can be slow on larger files. This results in a long checksumming process during automated packaging. By providing the option to hide the progress bar, while losing the "interactive" download update, we significantly increase the speed of the download.
Contributor
|
Looks like you changed the approach to just disable the progress status, rather than use WebClient. Did you want to update the PR title and description and then we can get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Updating the Get-RemoteChecksum function to leverage the .NET webclient vs
the Invoke-WebRequest to speed up the process significantly.
Motivation and Context
The current Get_RemoteChecksum implementation uses Invoke-WebRequest
which can be slow on larger files. This results in a long checksumming
process during automated packaging. By switching to the .NET webclient,
while losing the "interactive" download update (ie the ticker across the screen),
we significantly increase the speed of the download. For example, on a 150 mb
file, it went from minutes to download to seconds.
Testing
Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Issue #58
Fixes #58