Release 0.3.2#188
Conversation
|
If we want to make any other changes to our docs or README, this is the PR to do it, since after we merge this in, we will cut the release |
Codecov Report
Additional details and impacted files |
yuanqing-wang
left a comment
There was a problem hiding this comment.
Looks brilliant @mikemhenry . Thanks!
|
|
I can't seem to be able to make a multi row or coloum label in markdown (and I rather not have to breakout my html) is this clear? or confusing? better ideas? This would go in the readme
|
|
update:
|
|
Looks great! Do we want to add espaloma-0.2.x codes? Also, how about a cross (X) instead of a circle? Circles could have positive meanings, and I got slightly confused for a second. Or we could just use the check and leave not-supported as blank? |
|
one concern with the table is that if we have more models and code versions, the table will expand? trying to think if there is a better way. |
|
I wonder if something like the following would work?
EDIT: Or we could use the versions instead of the keyword |
|
Sorry I meant to use ❌ so that we also don't have an issue red-green color blindness as well. |
I can, but is espaloma-0.2.x relevant still? As in, do we want users to think about that version of the code? Our papers explain the versions used so I think that satisfies concerns about reproducibility. |
I think we only need to expand it for the same "family" of models, we could make a separate table for the |
|
or something like this one?
|
This isn't bad, I might change Thinking more, I would still put the code versions |
Oh Ken I really like this! I think that is a really good snapshot and has extra info that people are going to want to know about |
|
Took the idea from openff-forcefield. I thinks it flexible and extensible. We could add zenodo links to inform what datasets were used to train the model. |
|
I really like that idea, @kntkb . I would just add the |
|
Okay, adding Ken's table (and some emoji). I will track down the DOIs. I will also add a note explaining that espaloma-0.3.1.pt is the same as espaloma-0.3.2.pt |
|
Looks like zenodo wasn't turned on for espaloma, so I will add in the DOI after we make our release (zenodo gives you a DOI when you make a release, so I will make a PR after we make the release to update the README) |
PR for the 0.3.2 release