Add dihedral MCMove class#479
Open
zhang-ivy wants to merge 10 commits into
Open
Conversation
Contributor
Author
|
@dominicrufa any comments before I write some tests? |
dominicrufa
reviewed
Aug 27, 2020
dominicrufa
left a comment
Contributor
There was a problem hiding this comment.
looks good so far. proceed with tests.
Contributor
Author
|
@dominicrufa can you review again? |
Member
|
We'll update and merge this PR shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Subclass the MetropolizedMove to enable rigid rotations for a given dihedral.
Todos
Status