Skip to content

Fixes issue #694#704

Merged
ijpulidos merged 3 commits into
mainfrom
mikemhenry-patch-4
Jun 5, 2023
Merged

Fixes issue #694#704
ijpulidos merged 3 commits into
mainfrom
mikemhenry-patch-4

Conversation

@mikemhenry

@mikemhenry mikemhenry commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Description

Fixes metadata for netcdf files.

Todos

  • Implement feature / fix bug
  • Add tests
  • Update documentation as needed
  • Update changelog to summarize changes in behavior, enhancements, and bugfixes implemented in this PR

Status

  • Ready to go

Changelog message

Update metadata for netcdf files to mention openmmtools version used to create the file

@mikemhenry mikemhenry marked this pull request as ready for review June 5, 2023 20:01
@mikemhenry

Copy link
Copy Markdown
Contributor Author

How does this look @IAlibay

@IAlibay IAlibay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mikemhenry mikemhenry enabled auto-merge (squash) June 5, 2023 20:08

@ijpulidos ijpulidos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@ijpulidos ijpulidos added this to the 0.22.2 milestone Jun 5, 2023
@ijpulidos ijpulidos disabled auto-merge June 5, 2023 22:35
@ijpulidos ijpulidos merged commit c491c3d into main Jun 5, 2023
@ijpulidos ijpulidos deleted the mikemhenry-patch-4 branch June 5, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants