Skip to content

Drop older python version#714

Merged
mikemhenry merged 3 commits into
mainfrom
mikemhenry-patch-4
Nov 6, 2023
Merged

Drop older python version#714
mikemhenry merged 3 commits into
mainfrom
mikemhenry-patch-4

Conversation

@mikemhenry

Copy link
Copy Markdown
Contributor

Description

We can drop python 3.8 testing per NEP 29

Todos

  • Implement feature / fix bug
  • Add tests
  • Update documentation as needed
  • Update changelog to summarize changes in behavior, enhancements, and bugfixes implemented in this PR

Status

  • Ready to go

Changelog message


@mikemhenry mikemhenry requested a review from ijpulidos August 22, 2023 21:41
@mikemhenry

Copy link
Copy Markdown
Contributor Author

I added 3.11, if we have issues with solving we can remove it before merge.

@codecov

codecov Bot commented Aug 22, 2023

Copy link
Copy Markdown

Codecov Report

Merging #714 (145ef0b) into main (6cef59b) will not change coverage.
The diff coverage is n/a.

@mikemhenry

Copy link
Copy Markdown
Contributor Author

Looks like nose is unhappy

Comment thread .github/workflows/CI.yml Outdated
@mikemhenry

Copy link
Copy Markdown
Contributor Author

We can fix nose + py311 later

@mikemhenry

Copy link
Copy Markdown
Contributor Author

If 3.11 works we will close this pr and merge in this one #702 if 3.11 doesn't work, I will merge in this pr and close 702

@ijpulidos ijpulidos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikemhenry mikemhenry enabled auto-merge (squash) November 6, 2023 22:00
@mikemhenry mikemhenry merged commit 0b4d42a into main Nov 6, 2023
@mikemhenry mikemhenry deleted the mikemhenry-patch-4 branch November 6, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants