Fixes for numpy 2.0 (ruff NPY201)#777
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
Contributor
Author
|
cc @ijpulidos and @mikemhenry, looks lik ethis is all we needed? |
Contributor
|
that should do it, can you update the env yaml to pull in numpy 2.0 just as a quick check? |
mikemhenry
requested changes
Apr 22, 2025
mikemhenry
left a comment
Contributor
There was a problem hiding this comment.
just need to test numpy 2
Contributor
Author
|
@mikemhenry the 8.2 runners already pick up numpy 2.0 :) |
mikemhenry
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #772
Fixes for NP2.0 found by ruff.
Status
Changelog message