Error on $<num><non_num> capture replacement names
#258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Alright, I'm quite happy with things now. Most of the code is from implementing our own replacement capture parsing to match upstream or building up the custom error to show the user. Making sure that we match upstream's implementation was the part I was most concerned with, but I'm rather happy with how the tests turned out, so that should hopefully be fine This should be good enough to merge now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44
(Still a draft. Needs a lot of cleanup)This is a
mostlyworking implementation that errors on capture names that are a number followed by a non-number valid capture char (a-zA-Z_). It's a decent chunk of code mostly becauseregex-automatadoesn't expose a replacement capture name iterator (and couldn't without a non-trivial refactoring of their code based on the current implementation). Instead we provide our own which requires a lot of care to matchregex-automata's implementationAnyhoo, here's what the error looks like