Use modern Go constructs #42525

HadrienPatte · 2025-10-31T16:40:46Z

This PR is essentially the same thing as #38652 and related PRs.

I split the diff one commit per modernize category for easier code review, happy to squash those commits if it is preferred.

I skipped the following categories because they had larger diffs or potential compatibility impacts and should probably be handled in dedicated PRs:

omitzero: replace omitempty by omitzero on structs, added in go1.24.
bloop: replace "for i := range b.N" or "for range b.N" in a benchmark with "for b.Loop()", and remove any preceding calls to b.StopTimer, b.StartTimer, and b.ResetTimer.

B.Loop intentionally defeats compiler optimizations such as inlining so that the benchmark is not entirely optimized away. Currently, however, it may cause benchmarks to become slower in some cases due to increased allocation; see https://go.dev/issue/73137.
rangeint: replace a 3-clause "for i := 0; i < n; i++" loop by "for i := range n", added in go1.22.
waitgroup: replace old complex usages of sync.WaitGroup by less complex WaitGroup.Go method in go1.25.

Ideally we would add modernize to the CI test suite to ensure the codebase continues to follow those standards going forward, but modernize is not currently available as a golangci-lint plugin although there's ongoing work in that direction, see golangci/golangci-lint#686 (comment).
In the meantime, we could run modernize standalone alongside golangci-lint.

HadrienPatte · 2025-10-31T16:52:11Z

/test

MrFreezeex

Thanks! TIL about some of those new functions and LGTM for my codeowner.

pippolo84

Thanks! 💯

tklauser

Thanks!

cilium-cli/connectivity/check/features.go

tklauser · 2025-11-04T12:07:07Z

Ideally we would add modernize to the CI test suite to ensure the codebase continues to follow those standards going forward, but modernize is not currently available as a golangci-lint plugin although there's ongoing work in that direction, see golangci/golangci-lint#686 (comment). In the meantime, we could run modernize standalone alongside golangci-lint.

FWIW, golangci-lint includes the modernize linter since its 2.6.0 release so we could easily enable it (or parts of its checks) in CI now.

joestringer · 2025-11-04T17:23:42Z

Needs a rebase. Feel free to drop that label after you rebase. You will also need to resolve each comment thread on the PR before merge (but feel free to follow up separately on any non-blocking feedback if that's more convenient to you)

replace an if/else conditional assignment by a call to the built-in min or max functions added in go1.21. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>

replace interface{} by the 'any' type added in go1.18. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>

replace a loop around an m[k]=v map update by a call to one of the Collect, Copy, Clone, or Insert functions from the maps package, added in go1.21. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>

replace Split in "for range strings.Split(...)" by go1.24's more efficient SplitSeq, or Fields with FieldSeq. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>

replace some uses of HasPrefix followed by TrimPrefix with CutPrefix, added to the strings package in go1.20. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>

HadrienPatte · 2025-11-05T15:09:45Z

/test

… ) (#398) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [aqua:cilium/cilium-cli](https://redirect.github.com/cilium/cilium-cli) | patch | `0.18.7` -> `0.18.9` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>cilium/cilium-cli (aqua:cilium/cilium-cli)</summary> ### [`v0.18.9`](https://redirect.github.com/cilium/cilium-cli/releases/tag/v0.18.9) [Compare Source](https://redirect.github.com/cilium/cilium-cli/compare/v0.18.8...v0.18.9) ## Summary of Changes **Major Changes:** - Operator prometheus support TLS/mTLS using existing secret ([cilium/cilium#42077](https://redirect.github.com/cilium/cilium/issues/42077), [@phuhung273](https://redirect.github.com/phuhung273)) **Minor Changes:** - CLI: Allow users to set the default Cilium namespace via the CILIUM\_NAMESPACE environment variable ([cilium/cilium#41557](https://redirect.github.com/cilium/cilium/issues/41557), [@td0ne](https://redirect.github.com/td0ne)) - Removed deprecated `CiliumBGPPeeringPolicy` CRD and its agent implementation. Use `cilium.io/v2` CRDs (`CiliumBGPClusterConfig`, `CiliumBGPPeerConfig`, `CiliumBGPAdvertisement`, `CiliumBGPNodeConfigOverride`) for configuring BGP. ([cilium/cilium#42278](https://redirect.github.com/cilium/cilium/issues/42278), [@rastislavs](https://redirect.github.com/rastislavs)) **CI Changes:** - Add CCNP cilium connectivity tests ([cilium/cilium#42051](https://redirect.github.com/cilium/cilium/issues/42051), [@karina-ranadive](https://redirect.github.com/karina-ranadive)) - Fix connectivity tests for access to link-local nodelocaldns classified as 'host' entity ([cilium/cilium#42984](https://redirect.github.com/cilium/cilium/issues/42984), [@rptaylor](https://redirect.github.com/rptaylor)) **Misc Changes:** - bgp: Correct misleading error message in GetPeeringState ([cilium/cilium#42945](https://redirect.github.com/cilium/cilium/issues/42945), [@hargrovee](https://redirect.github.com/hargrovee)) - bgp: Remove versions from bgp package names ([cilium/cilium#42503](https://redirect.github.com/cilium/cilium/issues/42503), [@rastislavs](https://redirect.github.com/rastislavs)) - cilium-cli: add own type for root command parameters ([cilium/cilium#42609](https://redirect.github.com/cilium/cilium/issues/42609), [@tklauser](https://redirect.github.com/tklauser)) - cli: cleanups for pre-v1.15 removal ([cilium/cilium#42757](https://redirect.github.com/cilium/cilium/issues/42757), [@julianwiedmann](https://redirect.github.com/julianwiedmann)) - cli: require Cilium v1.15 ([cilium/cilium#41538](https://redirect.github.com/cilium/cilium/issues/41538), [@julianwiedmann](https://redirect.github.com/julianwiedmann)) - go.mod, vendor: bump github.com/google/go-github to v79 ([cilium/cilium#42857](https://redirect.github.com/cilium/cilium/issues/42857), [@tklauser](https://redirect.github.com/tklauser)) - Update lrp frontend IP address to avoid IMDS conflict in the cloud environment in cilium-cli ([cilium/cilium#42737](https://redirect.github.com/cilium/cilium/issues/42737), [@liyihuang](https://redirect.github.com/liyihuang)) - Use modern Go constructs ([cilium/cilium#42525](https://redirect.github.com/cilium/cilium/issues/42525), [@HadrienPatte](https://redirect.github.com/HadrienPatte)) - Update stable release to v0.18.8 by [@michi-covalent](https://redirect.github.com/michi-covalent) in [#3121](https://redirect.github.com/cilium/cilium-cli/pull/3121) - chore(deps): update actions/upload-artifact action to v5 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3124](https://redirect.github.com/cilium/cilium-cli/pull/3124) - chore(deps): update docker.io/library/golang:1.25.3 docker digest to [`8c945d3`](https://redirect.github.com/cilium/cilium-cli/commit/8c945d3) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3122](https://redirect.github.com/cilium/cilium-cli/pull/3122) - chore(deps): update dependency cilium/cilium to v1.18.3 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3123](https://redirect.github.com/cilium/cilium-cli/pull/3123) - chore(deps): update docker.io/library/golang:1.25.3 docker digest to [`6bac879`](https://redirect.github.com/cilium/cilium-cli/commit/6bac879) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3125](https://redirect.github.com/cilium/cilium-cli/pull/3125) - renovate: try to group dependency updates by [@tklauser](https://redirect.github.com/tklauser) in [#3126](https://redirect.github.com/cilium/cilium-cli/pull/3126) - chore(deps): update golangci/golangci-lint docker tag to v2.6.0 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3127](https://redirect.github.com/cilium/cilium-cli/pull/3127) - chore(deps): update helm/kind-action action to v1.13.0 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3128](https://redirect.github.com/cilium/cilium-cli/pull/3128) - chore(deps): update golangci/golangci-lint docker tag to v2.6.1 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3129](https://redirect.github.com/cilium/cilium-cli/pull/3129) - chore(deps): update golang docker tag to v1.25.4 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3130](https://redirect.github.com/cilium/cilium-cli/pull/3130) - chore(deps): update go to v1.25.4 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3131](https://redirect.github.com/cilium/cilium-cli/pull/3131) - chore(deps): update golang:1.25.4-alpine3.21 docker digest to [`3289aac`](https://redirect.github.com/cilium/cilium-cli/commit/3289aac) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3132](https://redirect.github.com/cilium/cilium-cli/pull/3132) - chore(deps): update docker.io/library/golang:1.25.4 docker digest to [`e68f6a0`](https://redirect.github.com/cilium/cilium-cli/commit/e68f6a0) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3135](https://redirect.github.com/cilium/cilium-cli/pull/3135) - chore(deps): update golangci/golangci-lint docker tag to v2.6.2 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3136](https://redirect.github.com/cilium/cilium-cli/pull/3136) - chore(deps): update golangci/golangci-lint-action action to v9 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3133](https://redirect.github.com/cilium/cilium-cli/pull/3133) - chore(deps): update dependency cilium/cilium to v1.18.4 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3134](https://redirect.github.com/cilium/cilium-cli/pull/3134) - chore(deps): update all github action dependencies by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3137](https://redirect.github.com/cilium/cilium-cli/pull/3137) - chore(deps): update actions/setup-go action to v6.1.0 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3138](https://redirect.github.com/cilium/cilium-cli/pull/3138) - chore(deps): update actions/checkout action to v6 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3139](https://redirect.github.com/cilium/cilium-cli/pull/3139) - chore(deps): update golangci/golangci-lint-action action to v9.1.0 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3141](https://redirect.github.com/cilium/cilium-cli/pull/3141) - chore(deps): update docker.io/library/golang:1.25.4 docker digest to [`f60eaa8`](https://redirect.github.com/cilium/cilium-cli/commit/f60eaa8) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3140](https://redirect.github.com/cilium/cilium-cli/pull/3140) - chore(deps): update docker.io/library/golang:1.25.4 docker digest to [`6981837`](https://redirect.github.com/cilium/cilium-cli/commit/6981837) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3143](https://redirect.github.com/cilium/cilium-cli/pull/3143) - chore(deps): update softprops/action-gh-release action to v2.5.0 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3144](https://redirect.github.com/cilium/cilium-cli/pull/3144) - chore(deps): update golang docker tag to v1.25.5 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3147](https://redirect.github.com/cilium/cilium-cli/pull/3147) - chore(deps): update actions/checkout action to v6.0.1 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3146](https://redirect.github.com/cilium/cilium-cli/pull/3146) - Prepare for v0.18.9 release by [@michi-covalent](https://redirect.github.com/michi-covalent) in [#3145](https://redirect.github.com/cilium/cilium-cli/pull/3145) **Full Changelog**: <cilium/cilium-cli@v0.18.8...v0.18.9> ### [`v0.18.8`](https://redirect.github.com/cilium/cilium-cli/releases/tag/v0.18.8) [Compare Source](https://redirect.github.com/cilium/cilium-cli/compare/v0.18.7...v0.18.8) ## Summary of Changes **Minor Changes:** - clustermesh: add endpoints metrics and change global service (and MCS ServiceExport) metrics to report per cluster metrics instead of a global count ([cilium/cilium#41323](https://redirect.github.com/cilium/cilium/issues/41323), [@MrFreezeex](https://redirect.github.com/MrFreezeex)) **Bugfixes:** - cilium-cli: Fix CNI config file collection in sysdump ([cilium/cilium#42111](https://redirect.github.com/cilium/cilium/issues/42111), [@pillai-ashwin](https://redirect.github.com/pillai-ashwin)) - cilium-cli: Prevent panic in `node-to-node-encryption` connectivity test ([cilium/cilium#41600](https://redirect.github.com/cilium/cilium/issues/41600), [@HadrienPatte](https://redirect.github.com/HadrienPatte)) - connectivity-tests: limit IPv6 PodToIngress to Cilium >= v1.17 ([cilium/cilium#42148](https://redirect.github.com/cilium/cilium/issues/42148), [@julianwiedmann](https://redirect.github.com/julianwiedmann)) - Fix a fatal error when accessing multicast map using cilium-dbg bpf multicast ([cilium/cilium#42080](https://redirect.github.com/cilium/cilium/issues/42080), [@tklauser](https://redirect.github.com/tklauser)) **CI Changes:** - Add integration test to validate IPsec key derivation consistency across nodes, ensuring tunnel keys are properly derived and identical between Cilium pods. ([cilium/cilium#40808](https://redirect.github.com/cilium/cilium/issues/40808), [@pillai-ashwin](https://redirect.github.com/pillai-ashwin)) - ci: enable copyloopvar linter ([cilium/cilium#41893](https://redirect.github.com/cilium/cilium/issues/41893), [@tklauser](https://redirect.github.com/tklauser)) - cilium-cli, netns: fix golangci-lint 2.5.0 errors ([cilium/cilium#41856](https://redirect.github.com/cilium/cilium/issues/41856), [@tklauser](https://redirect.github.com/tklauser)) - cilium-cli: Bring back NodePort Acceleration feature detection ([cilium/cilium#41812](https://redirect.github.com/cilium/cilium/issues/41812), [@brb](https://redirect.github.com/brb)) - cilium-cli: Reenable L7 IPv6 tests ([cilium/cilium#39662](https://redirect.github.com/cilium/cilium/issues/39662), [@gentoo-root](https://redirect.github.com/gentoo-root)) - cilium-cli: Specify TARGET for building release binaries ([cilium/cilium#42177](https://redirect.github.com/cilium/cilium/issues/42177), [@michi-covalent](https://redirect.github.com/michi-covalent)) - cilium\_cli: Override GO\_BUILD Make variable ([cilium/cilium#42162](https://redirect.github.com/cilium/cilium/issues/42162), [@michi-covalent](https://redirect.github.com/michi-covalent)) - cli, ipsec: Fix bidirectional IPsec tunnel check ([cilium/cilium#42047](https://redirect.github.com/cilium/cilium/issues/42047), [@pchaigno](https://redirect.github.com/pchaigno)) - cli: Fix unreliable tests due to error emitted in Cilium logs "retrieving device lxc\*: Link not found" ([cilium/cilium#42146](https://redirect.github.com/cilium/cilium/issues/42146), [@fristonio](https://redirect.github.com/fristonio)) **Misc Changes:** - chore(deps): update all-dependencies (main) ([cilium/cilium#41611](https://redirect.github.com/cilium/cilium/issues/41611), [@cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot]) - chore(deps): update all-dependencies (main) ([cilium/cilium#42018](https://redirect.github.com/cilium/cilium/issues/42018), [@cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot]) - chore(deps): update docker.io/alpine/socat:1.8.0.3 docker digest to [`0ce60b5`](https://redirect.github.com/cilium/cilium-cli/commit/0ce60b5) (main) ([cilium/cilium#41558](https://redirect.github.com/cilium/cilium/issues/41558), [@cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot]) - chore(deps): update docker.io/library/golang:1.25.1 docker digest to [`8305f5f`](https://redirect.github.com/cilium/cilium-cli/commit/8305f5f) (main) ([cilium/cilium#41649](https://redirect.github.com/cilium/cilium/issues/41649), [@cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot]) - chore(deps): update docker.io/library/golang:1.25.1 docker digest to [`d709837`](https://redirect.github.com/cilium/cilium-cli/commit/d709837) (main) ([cilium/cilium#42019](https://redirect.github.com/cilium/cilium/issues/42019), [@cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot]) - chore(deps): update docker.io/library/golang:1.25.3 docker digest to [`6ea52a0`](https://redirect.github.com/cilium/cilium-cli/commit/6ea52a0) (main) ([cilium/cilium#42252](https://redirect.github.com/cilium/cilium/issues/42252), [@cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot]) - chore(deps): update go to v1.25.1 (main) ([cilium/cilium#41560](https://redirect.github.com/cilium/cilium/issues/41560), [@cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot]) - chore(deps): update go to v1.25.3 (main) ([cilium/cilium#42061](https://redirect.github.com/cilium/cilium/issues/42061), [@cilium-renovate](https://redirect.github.com/cilium-renovate)\[bot]) - cilium-cli/features: use common cmd metric list command ([cilium/cilium#41630](https://redirect.github.com/cilium/cilium/issues/41630), [@aanm](https://redirect.github.com/aanm)) - cilium-cli: drop disabled IP cache check from connectivity tests ([cilium/cilium#42240](https://redirect.github.com/cilium/cilium/issues/42240), [@tklauser](https://redirect.github.com/tklauser)) - cli/clustermesh: remove leftover global services status info ([cilium/cilium#41727](https://redirect.github.com/cilium/cilium/issues/41727), [@giorio94](https://redirect.github.com/giorio94)) - Refactor policy engine to use PolicyEntry as the internal representation of policies, as described in CFP-39646. ([cilium/cilium#40213](https://redirect.github.com/cilium/cilium/issues/40213), [@TheBeeZee](https://redirect.github.com/TheBeeZee)) - sysdump: add resource usage of nodes and pods ([cilium/cilium#41415](https://redirect.github.com/cilium/cilium/issues/41415), [@darox](https://redirect.github.com/darox)) - chore(deps): update go to v1.25.1 (patch) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3097](https://redirect.github.com/cilium/cilium-cli/pull/3097) - chore(deps): update actions/setup-go action to v6 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3094](https://redirect.github.com/cilium/cilium-cli/pull/3094) - chore(deps): update docker.io/library/golang:1.25.1 docker digest to [`d6bdb04`](https://redirect.github.com/cilium/cilium-cli/commit/d6bdb04) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3096](https://redirect.github.com/cilium/cilium-cli/pull/3096) - chore(deps): update gcr.io/distroless/static:latest docker digest to [`87bce11`](https://redirect.github.com/cilium/cilium-cli/commit/87bce11) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3099](https://redirect.github.com/cilium/cilium-cli/pull/3099) - chore(deps): update softprops/action-gh-release action to v2.3.3 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3098](https://redirect.github.com/cilium/cilium-cli/pull/3098) - chore(deps): update golang docker tag to v1.25.1 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3093](https://redirect.github.com/cilium/cilium-cli/pull/3093) - chore(deps): update actions/stale action to v10 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3095](https://redirect.github.com/cilium/cilium-cli/pull/3095) - chore(deps): update golang:1.25.1-alpine3.21 docker digest to [`331bde4`](https://redirect.github.com/cilium/cilium-cli/commit/331bde4) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3100](https://redirect.github.com/cilium/cilium-cli/pull/3100) - chore(deps): update dependency cilium/cilium to v1.18.2 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3102](https://redirect.github.com/cilium/cilium-cli/pull/3102) - chore(deps): update docker.io/library/golang:1.25.1 docker digest to [`8305f5f`](https://redirect.github.com/cilium/cilium-cli/commit/8305f5f) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3103](https://redirect.github.com/cilium/cilium-cli/pull/3103) - chore(deps): update golangci/golangci-lint docker tag to v2.5.0 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3104](https://redirect.github.com/cilium/cilium-cli/pull/3104) - chore(deps): update docker/login-action action to v3.6.0 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3105](https://redirect.github.com/cilium/cilium-cli/pull/3105) - chore(deps): update docker.io/library/golang:1.25.1 docker digest to [`ab1f5c4`](https://redirect.github.com/cilium/cilium-cli/commit/ab1f5c4) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3106](https://redirect.github.com/cilium/cilium-cli/pull/3106) - chore(deps): update actions/stale action to v10.1.0 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3108](https://redirect.github.com/cilium/cilium-cli/pull/3108) - chore(deps): update softprops/action-gh-release action to v2.3.4 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3107](https://redirect.github.com/cilium/cilium-cli/pull/3107) - chore(deps): update softprops/action-gh-release action to v2.4.0 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3109](https://redirect.github.com/cilium/cilium-cli/pull/3109) - chore(deps): update golang docker tag to v1.25.2 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3110](https://redirect.github.com/cilium/cilium-cli/pull/3110) - chore(deps): update go to v1.25.2 (patch) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3112](https://redirect.github.com/cilium/cilium-cli/pull/3112) - chore(deps): update golang:1.25.2-alpine3.21 docker digest to [`0134653`](https://redirect.github.com/cilium/cilium-cli/commit/0134653) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3113](https://redirect.github.com/cilium/cilium-cli/pull/3113) - RELEASE: also look for release-blockers in cilium/cilium by [@julianwiedmann](https://redirect.github.com/julianwiedmann) in [#3116](https://redirect.github.com/cilium/cilium-cli/pull/3116) - chore(deps): update golang docker tag to v1.25.3 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3117](https://redirect.github.com/cilium/cilium-cli/pull/3117) - chore(deps): update softprops/action-gh-release action to v2.4.1 by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3114](https://redirect.github.com/cilium/cilium-cli/pull/3114) - chore(deps): update go to v1.25.3 (patch) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3118](https://redirect.github.com/cilium/cilium-cli/pull/3118) - chore(deps): update golang:1.25.3-alpine3.21 docker digest to [`0c9f3e0`](https://redirect.github.com/cilium/cilium-cli/commit/0c9f3e0) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3115](https://redirect.github.com/cilium/cilium-cli/pull/3115) - Makefile: fix renovate depname for GO\_IMAGE\_\* updates by [@tklauser](https://redirect.github.com/tklauser) in [#3119](https://redirect.github.com/cilium/cilium-cli/pull/3119) - chore(deps): update docker.io/library/golang:1.25.3 docker digest to [`6ea52a0`](https://redirect.github.com/cilium/cilium-cli/commit/6ea52a0) by [@renovate](https://redirect.github.com/renovate)\[bot] in [#3111](https://redirect.github.com/cilium/cilium-cli/pull/3111) - Prepare for v0.18.8 release by [@michi-covalent](https://redirect.github.com/michi-covalent) in [#3120](https://redirect.github.com/cilium/cilium-cli/pull/3120) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate).  Co-authored-by: zocimek-renovate[bot] <134739422+zocimek-renovate[bot]@users.noreply.github.com> Co-authored-by: Łukasz Pospiech <zocimek@users.noreply.github.com>

maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 31, 2025

github-actions bot added the cilium-cli This PR contains changes related with cilium-cli label Oct 31, 2025

HadrienPatte added the release-note/misc This PR makes changes that have no direct user impact. label Oct 31, 2025

maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 31, 2025

HadrienPatte marked this pull request as ready for review October 31, 2025 17:52

HadrienPatte requested review from a team as code owners October 31, 2025 17:52

HadrienPatte requested review from MrFreezeex, asauber, christarazi, pippolo84, rastislavs and tklauser October 31, 2025 17:52

MrFreezeex approved these changes Nov 2, 2025

View reviewed changes

pippolo84 approved these changes Nov 3, 2025

View reviewed changes

rastislavs approved these changes Nov 3, 2025

View reviewed changes

christarazi approved these changes Nov 3, 2025

View reviewed changes

asauber approved these changes Nov 4, 2025

View reviewed changes

tklauser approved these changes Nov 4, 2025

View reviewed changes

cilium-cli/connectivity/check/features.go Outdated Show resolved Hide resolved

tklauser enabled auto-merge November 4, 2025 08:10

maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Nov 4, 2025

joestringer added dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Nov 4, 2025

HadrienPatte added 5 commits November 5, 2025 15:56

modernize: minmax

46ad006

replace an if/else conditional assignment by a call to the built-in min or max functions added in go1.21. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>

modernize: efaceany

3024741

replace interface{} by the 'any' type added in go1.18. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>

modernize: mapsloop

ec6bcbb

replace a loop around an m[k]=v map update by a call to one of the Collect, Copy, Clone, or Insert functions from the maps package, added in go1.21. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>

modernize: stringsseq

f6609f7

replace Split in "for range strings.Split(...)" by go1.24's more efficient SplitSeq, or Fields with FieldSeq. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>

modernize: stringscutprefix

b0211fc

replace some uses of HasPrefix followed by TrimPrefix with CutPrefix, added to the strings package in go1.20. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>

HadrienPatte force-pushed the pr/HadrienPatte/modernize branch from f450fa0 to b0211fc Compare November 5, 2025 15:07

HadrienPatte removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Nov 5, 2025

tklauser added dont-merge/bad-bot To prevent MLH from marking ready-to-merge. and removed dont-merge/bad-bot To prevent MLH from marking ready-to-merge. labels Nov 5, 2025

HadrienPatte removed the release-note/misc This PR makes changes that have no direct user impact. label Nov 5, 2025

maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 5, 2025

HadrienPatte added the release-note/misc This PR makes changes that have no direct user impact. label Nov 5, 2025

maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 5, 2025

tklauser added this pull request to the merge queue Nov 5, 2025

maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 5, 2025

Merged via the queue into main with commit 34f7885 Nov 5, 2025
339 of 340 checks passed

tklauser deleted the pr/HadrienPatte/modernize branch November 5, 2025 16:09

HadrienPatte mentioned this pull request Nov 6, 2025

ci: Enable modernize golangci-lint linter #42642

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use modern Go constructs #42525

Use modern Go constructs #42525

HadrienPatte commented Oct 31, 2025

Uh oh!

HadrienPatte commented Oct 31, 2025

Uh oh!

MrFreezeex left a comment

Uh oh!

pippolo84 left a comment

Uh oh!

tklauser left a comment

Uh oh!

Uh oh!

tklauser commented Nov 4, 2025

Uh oh!

joestringer commented Nov 4, 2025

Uh oh!

HadrienPatte commented Nov 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Use modern Go constructs #42525

Use modern Go constructs #42525

Conversation

HadrienPatte commented Oct 31, 2025

Uh oh!

HadrienPatte commented Oct 31, 2025

Uh oh!

MrFreezeex left a comment

Choose a reason for hiding this comment

Uh oh!

pippolo84 left a comment

Choose a reason for hiding this comment

Uh oh!

tklauser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tklauser commented Nov 4, 2025

Uh oh!

joestringer commented Nov 4, 2025

Uh oh!

HadrienPatte commented Nov 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants