cleanup: unused Acet and ISE procedures and improve taskfile #5231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtifacts Remove unused AcetAnswerDistribution and IseAnswerDistribution methods along with their associated result classes. These stored procedures are no longer used in the codebase. - Delete AcetAnswerDistribution_Result.cs (manual class) - Delete AcetAnswerDistributionResult.cs (auto-generated model) - Remove AcetAnswerDistribution and IseAnswerDistribution from CSETContext - Remove AcetAnswerDistributionAsync from CsetwebContextProcedures - Update ICsetwebContextProcedures interface - Remove procedure from efpt.config.json scaffold configuration
- Remove unused Microsoft.Data.SqlClient import from CompletionCounter.cs - Fix trailing whitespace in ImportManager.cs and CompletionCounter.cs
- Rename check:backend to verify:backend for format verification - Add new check:backend that runs build, lint, and test in parallel - Fix sql task to connect directly to CSET database - Normalize quote style to double quotes for consistency
Pass Configuration to ImportManager constructor in AssessmentsDuplicator to ensure proper configuration is available during bulk import operations.
Add sql:query and sql:file tasks to enable programmatic database exploration. These tasks are designed for coding agents like Claude Code to execute queries without requiring interactive shell access. Also updates the sql task to use mssql-tools18 with TLS certificate verification disabled (-C flag).
…IseAnswerDistribution procedures
randywoods
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes unused AcetAnswerDistribution stored procedure artifacts from the codebase and improves the taskfile with better backend check commands.
Commits
92b06a41frefactor(datalayer): remove AcetAnswerDistribution stored procedure artifactse639bc2edchore(business): clean up trailing whitespace and remove unused importe3f94e9edchore(taskfile): improve backend checks and SQL shell commandChanges
AcetAnswerDistributionandIseAnswerDistributionmethods from CSETContextAcetAnswerDistribution_Result.csandAcetAnswerDistributionResult.csmodel classesAcetAnswerDistributionAsyncfrom generated stored procedure interfacesMicrosoft.Data.SqlClientimport from CompletionCounter.cscheck:backendtoverify:backendfor format verificationcheck:backendthat runs build, lint, and test in parallelsqltask to connect directly to CSET databaseBreaking Changes
None
Test Plan
task build:backendto verify backend builds successfullytask test:backendto verify all tests passtask check:backendto verify new parallel check command workstask sqland verify it connects to CSET database directlyRelated Issues
None
Release Notes
Cleanup of unused stored procedure artifacts and improvements to developer experience with better taskfile commands.
Checklist