Fix the issue #3837 #3868
Merged
Fix the issue #3837 #3868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revive the code removed in the commit c0e5ea2. Not quite sure now, why it was decided to be removed.
rona901
approved these changes
Mar 18, 2025
|
I can confirm that this fixed #3837. Thank you! |
torokati44
pushed a commit
to torokati44/openh264
that referenced
this pull request
Apr 14, 2025
Revive the code removed in the commit c0e5ea2. Not quite sure now, why it was decided to be removed.
|
Is there still no release at all with this patch included? 😨 |
normalcea
added a commit
to normalcea/nixpkgs
that referenced
this pull request
Oct 5, 2025
Cisco openh264 won't cut a 2.5.2 release for ruffle and so ruffle upstream has decided to hold back their openh264 dependency due to flatpak dropping it due to ABI breakage. Instead, patch ruffle to accept any openh264 version in nixpkgs. - cisco/openh264#3837 (original issue) - cisco/openh264#3868 (patch) - cisco/openh264#3873 (reason for using 2.4.1) This removes the security vulnerability CVEs for 2.4.1.
normalcea
added a commit
to normalcea/nixpkgs
that referenced
this pull request
Oct 5, 2025
Cisco openh264 won't cut a 2.5.2 release for ruffle and so ruffle upstream has decided to hold back their openh264 dependency due to flatpak dropping it due to ABI breakage. Instead, patch ruffle to accept any openh264 version in nixpkgs. - cisco/openh264#3837 (original issue) - cisco/openh264#3868 (patch) - cisco/openh264#3873 (reason for using 2.4.1) This removes the security vulnerability CVEs for 2.4.1.
normalcea
added a commit
to normalcea/nixpkgs
that referenced
this pull request
Oct 5, 2025
Cisco openh264 won't cut a 2.5.2 release for ruffle and so ruffle upstream has decided to hold back their openh264 dependency due to flatpak dropping it due to ABI breakage. Instead, patch ruffle to accept any openh264 version in nixpkgs. - cisco/openh264#3837 (original issue) - cisco/openh264#3868 (patch) - cisco/openh264#3873 (reason for using 2.4.1) This removes the security vulnerability CVEs for 2.4.1.
normalcea
added a commit
to normalcea/nixpkgs
that referenced
this pull request
Oct 6, 2025
Cisco openh264 won't cut a 2.5.2 release for ruffle and so ruffle upstream has decided to hold back their openh264 dependency due to flatpak dropping it due to ABI breakage. Instead, patch ruffle to accept any openh264 version in nixpkgs. - cisco/openh264#3837 (original issue) - cisco/openh264#3868 (patch) - cisco/openh264#3873 (reason for using 2.4.1) This removes the security vulnerability CVEs for 2.4.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revive the code removed in the commit c0e5ea2. Not quite sure now, why it was decided to be removed.