Change crypto config, use one option with a list of values #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new option CRYPTO_LIBRARY that replaces all the ENABLE_XXXX options. This makes it a little simpler and removes the possibility of configuring multiple backends. The name CRYPTO_LIBRARY is the same value currently used in the meson build. cisco#697
Add a new option --with-crypto-library that replaces all the --enabled-xxxx options. This makes it a little simpler and removes the possibility of configuring multiple backends. cisco#697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from multiple options to a single one with many possible values.
The name crypto library was already used by meson so keep with that but
make it fit the norms of each each build system.
cmkae -DCRYPTO_LIBRARY=openssl
configure --with-crypto-library=openssl
meson configure -Dcrypto-library=openssl
#697