Improve installation paths on windows #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps windows libraries get installed to ``` bin\srtp2.dll lib\srtp2.lib ``` This is the split we use at conda-forge to help keep the dlls findable while keeking the lib files separate. Let me know if you have any concerns. Excited to see this upstreamed.
|
Hi @hmaarrfk, this should be ok. I wish these build systems where more standardized, and sometimes your wishes come true :) ... according to https://cmake.org/cmake/help/latest/command/install.html the built-in defaults values should be as you suggested so maybe the best change is to just remove the "DESTINATION lib". I have checked that it works on linux, if it also works for you maybe you can change the PR? |
|
lets see what happens conda-forge/libsrtp2-feedstock#2 |
|
sigh i guess the patch is different for the released version. it will have to wait |
|
With #772 there is now a CI task that does an install so we can see the result. I tested and it seams to work as expected with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps windows libraries get installed to
This is the split we use at conda-forge to help keep the dlls findable while keeking the lib files separate.
Let me know if you have any concerns.
Excited to see this upstreamed.