Remove unused statistics collection #8174
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8174 +/- ##
==========================================
+ Coverage 88.95% 89.12% +0.17%
==========================================
Files 287 286 -1
Lines 63136 63006 -130
Branches 7941 7928 -13
==========================================
- Hits 56163 56156 -7
+ Misses 4663 4539 -124
- Partials 2310 2311 +1 🚀 New features to boost your workflow:
|
|
Should remove citus_server_id() in 14.0 sql script once #8170 is merged. update: No, won't remove it as it's still indirectly used by IsWorkerTheCurrentNode(). In other words, we should still have server_id in pg_dist_node_metadata, which is generated by citus_server_id(). |
| docdir | ||
| oldincludedir | ||
| includedir | ||
| runstatedir |
There was a problem hiding this comment.
are the runstatedir changes related to this diff or an accident.
a quick search only shows the term in the configure section, so it seems unrelated, but didn't look deeply
There was a problem hiding this comment.
Not really sure why but when I revert everything and reapply the changes one by one again (i.e., do the C changes, remove libcurl & reports related bits from ac file and re-run autoreconf -f), again I got the exactly same patch, with autoconf == 2.69, which already seems to be the version we've been using based on the comments on top of configure
it's still used, by IsWorkerTheCurrentNode()
| * modeled after PostgreSQL's pg_random_uuid(). | ||
| */ | ||
| Datum | ||
| citus_server_id(PG_FUNCTION_ARGS) |
There was a problem hiding this comment.
moved from src/backend/distributed/utils/statistics_collection.c as is
DESCRIPTION: Stops on-demand statistics collection for clusters and deprecates citus.enable_statistics_collection GUC.