Disk Image Feature #244
Merged
Disk Image Feature #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ListDiskImages function now accepts an optional includeCustom parameter to filter custom disk images.
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
disk_image.go:34
- [nitpick] The JSON key for image size is 'image_size_bytes' in the request struct but 'image_size' in the response struct. Consider aligning these names for consistency if it fits the API design.
ImageSize int64 `json:"image_size_bytes"` // Changed from image_size to image_size_bytes
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
disk_image.go:48
- [nitpick] The 'ImageSize' field in CreateDiskImageResponse uses a JSON tag 'image_size', which differs from the 'image_size_bytes' tag used in CreateDiskImageParams. Consider aligning these tags for consistency.
ImageSize int64 `json:"image_size"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.