Skip to content

Playback fixes/updates and performance improvements #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 13, 2024
Merged

Playback fixes/updates and performance improvements #2188

merged 8 commits into from
Aug 13, 2024

Conversation

@jhonatangcavalcanti
Copy link
Member

@jhonatangcavalcanti jhonatangcavalcanti commented Aug 12, 2024 •
edited
Loading

This MR brings several improvements and fixes listed below:

  • hlsjs-playback
    • Upgrade hls.js to the latest version (1.5.14) Update hls.js version #2146
    • Prevent playback from staying paused when recovering from hlsjs media error
  • dash-shaka-playback
    • Add more error-related info from the shaka player to the playback_error event payload
    • Prevent accumulation of setIntervals
  • hlsjs-playback, dash-shaka-playback
    • Reduce the number of calls of timeupdate events
  • hlsjs-playback, dash-shaka-playback and html5_video
    • Fix the DVR state when pausing/seeking externally from the player and remove duplicated code
  • Log
    • Add core:mousemove to exclude list
    • Check by level before looking into exclude_list array

@jhonatangcavalcanti jhonatangcavalcanti changed the title Playback and performance improvements Playback fixes/updates and performance improvements Aug 12, 2024
@jhonatangcavalcanti jhonatangcavalcanti force-pushed the feature/playback-and-performance-improvements branch from d9f4189 to 2735371 Compare August 12, 2024 23:19
@jhonatangcavalcanti
fix(playbacks): update dvr status on pause and seeking events
eaf8a9f 
When the player is externally paused/seek, the DVR information was not being set since it was only
updated when called via playback pause/seek methods. Besides that, duplicated code related to DVR
was removed from playbacks.
@jhonatangcavalcanti
chore: upgrade hls.js to latest version
d0601ee
@jhonatangcavalcanti
fix(hlsjs-playback): play media after media error recover
28e14bc 
The player stays in paused stated after calling the recoverMediaError method
@jhonatangcavalcanti
feat(playbacks): reduce number of calls of timeupdate event with the …
d19cfc7 
…same payload
@jhonatangcavalcanti jhonatangcavalcanti force-pushed the feature/playback-and-performance-improvements branch from 2735371 to d19cfc7 Compare August 13, 2024 13:52
@jhonatangcavalcanti jhonatangcavalcanti merged commit 92fc5e7 into main Aug 13, 2024
@jhonatangcavalcanti jhonatangcavalcanti deleted the feature/playback-and-performance-improvements branch August 13, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arielfurtado arielfurtado arielfurtado approved these changes

@paulocesarjr paulocesarjr paulocesarjr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jhonatangcavalcanti @arielfurtado @paulocesarjr