Skip to content

Fix compile warnings #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AntoineRondelet merged 6 commits into from
Aug 8, 2019
Merged

Fix compile warnings #33

AntoineRondelet merged 6 commits into from
Aug 8, 2019

Conversation

@dtebbs
Copy link
Contributor

@dtebbs dtebbs commented Jul 19, 2019

Trivial changes to remove some of the compile warnings, to help catch issues in internal code. Some warnings are still present for now.

@dtebbs dtebbs force-pushed the fix-compile-warnings branch 3 times, most recently from a477855 to 65b9ec9 Compare July 31, 2019 10:22
@dtebbs dtebbs changed the title Fix compile warnings [WIP] Fix compile warnings Jul 31, 2019
@dtebbs dtebbs changed the title [WIP] Fix compile warnings Fix compile warnings Aug 7, 2019
@dtebbs dtebbs force-pushed the fix-compile-warnings branch from 65b9ec9 to 11daa4c Compare August 7, 2019 08:46
@dtebbs dtebbs force-pushed the fix-compile-warnings branch from 11daa4c to 6dcacd0 Compare August 8, 2019 17:46
@dtebbs
Copy link
Contributor Author

dtebbs commented Aug 8, 2019

Changed based on discussion, and rebased.

@AntoineRondelet
Copy link
Contributor

AntoineRondelet commented Aug 8, 2019

Thanks!

@AntoineRondelet AntoineRondelet merged commit 4b406ea into develop Aug 8, 2019
@AntoineRondelet AntoineRondelet deleted the fix-compile-warnings branch August 9, 2019 20:35
@AntoineRondelet AntoineRondelet added the build Task related to the compilation and execution of the project label Aug 13, 2019
AntoineRondelet added a commit that referenced this pull request May 6, 2020
@AntoineRondelet
Merge pull request #33 from clearmatics/fix-compile-warnings
982a813 
Fix compile warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build Task related to the compilation and execution of the project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dtebbs @AntoineRondelet