Skip to content

Migrate docker build from DockerHub to GitHub Container Registry #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AntoineRondelet merged 3 commits into from
Feb 9, 2021
Merged

Migrate docker build from DockerHub to GitHub Container Registry #350

AntoineRondelet merged 3 commits into from
Feb 9, 2021

Conversation

@eastata
Copy link
Contributor

@eastata eastata commented Feb 5, 2021 •
edited
Loading

The issue is a part of global migration from DockerHub to GitHub Container Registry.

  • Docker images for applications mpc, client, prover

    • builded by buildx for linux/amd64. List of platform can be extended for the future
    • building use contaner registry as a remote docker cache cache-mpc, cache-client, cache-prover
    • initial build generate docker images with tags based on git hash. Workflow is ready for extention by docker-compose for integral tests
    • Build triggered by release tag vX.Y.Z

  • Base image still the same, only migrated to GitHub CR

    • Build triggered by release tag docker-base-vX.Y.Z

Docker images

Docker files Image Tags Description
./Dockerfile-prover ghcr.io/clearmatics/zeth:latest-prover latest-prover, X.Y.Z-prover - Release of zeth, git-%HASH%-prover - developers build by git-commit Zeth Prover Server. Image use zeth-base for building
./Dockerfile-client ghcr.io/clearmatics/zeth:latest-client latest-client, X.Y.Z-client - Release of zeth, git-%HASH%-client - developers build by git-commit Python client to interact with the prover
./Dockerfile-mpc ghcr.io/clearmatics/zeth:latest-mpc latest-mpc, X.Y.Z-mpc - Release of zeth, git-%HASH%-mpc - developers build by git-commit Tools for Multi-Party Computation. Image use zeth-base for building
./Dockerfile-base ghcr.io/clearmatics/zeth:latest-base latest-base, A.B.C-base - Release of zeth-base Base image for building other containers

@eastata eastata marked this pull request as draft February 5, 2021 15:43
@eastata eastata changed the title [WIP] Migrate docker build from DockerHub to GitHub Container Registry Migrate docker build from DockerHub to GitHub Container Registry Feb 5, 2021
@eastata eastata marked this pull request as ready for review February 5, 2021 15:54
@eastata eastata self-assigned this Feb 5, 2021
dtebbs
dtebbs approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@dtebbs dtebbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AntoineRondelet
AntoineRondelet reviewed Feb 8, 2021
View reviewed changes
@AntoineRondelet
Copy link
Contributor

AntoineRondelet commented Feb 8, 2021 

* Build triggered by release tag `vX.Y.Z`

@eastata - can we still manually push docker images to this registry? I'd like to push the "application images" for the 0.5 and 0.6 tags (which I guess, won't be re-built - or will they?)

@eastata
Copy link
Contributor Author

eastata commented Feb 8, 2021

can we still manually push docker images to this registry

Yes. You have to configure docker client using GITHUB_TOKEN

@AntoineRondelet
Copy link
Contributor

AntoineRondelet commented Feb 9, 2021

can we still manually push docker images to this registry

Yes. You have to configure docker client using GITHUB_TOKEN

I see, thanks @eastata

@AntoineRondelet AntoineRondelet self-requested a review February 9, 2021 10:53
AntoineRondelet
AntoineRondelet approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@AntoineRondelet AntoineRondelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @eastata!

@AntoineRondelet AntoineRondelet merged commit b39479e into develop Feb 9, 2021
@eastata eastata deleted the github-CR branch February 9, 2021 14:28
@AntoineRondelet AntoineRondelet mentioned this pull request Feb 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dtebbs dtebbs dtebbs approved these changes

@AntoineRondelet AntoineRondelet AntoineRondelet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@eastata eastata

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eastata @AntoineRondelet @dtebbs