fix: xmake spdlog force non-system#299
Conversation
WalkthroughRefactors Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
xmake.lua (1)
43-44: Fix correctly forces non-system spdlog to resolve incompatibility.The
system=falsesetting directly addresses issue #298 by ensuring xmake builds or fetches a compatible spdlog version instead of using the system-installed spdlog 1.16.0 that caused compilation errors with fmt 12.1.0. The config values are correctly preserved (header_only=false,std_format=true,noexcept=true), and separating spdlog into its ownadd_requirescall is the appropriate way to apply package-specific settings in xmake.Consider adding a brief comment above line 43 explaining why
system=falseis required (e.g.,-- Force non-system spdlog to avoid compatibility issues with system fmt versions (issue #298)), which would help future maintainers understand this constraint.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
xmake.lua(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: macos (macos-15, debug)
- GitHub Check: linux (ubuntu-24.04, release)
- GitHub Check: macos (macos-15, release)
- GitHub Check: linux (ubuntu-24.04, debug)
- GitHub Check: windows (windows-2025)
Signed-off-by: 蔡略 <cailue@apache.org>
1d3ce04 to
1b98a49
Compare
This fixes #298 on my WSL machine.
Summary by CodeRabbit