Skip to content

gh-405: fix COSEBIs key bug#406

Merged
gcanasherrera merged 1 commit into
mainfrom
405-bug-in-key-of-cosebis
Jan 28, 2026
Merged

gh-405: fix COSEBIs key bug#406
gcanasherrera merged 1 commit into
mainfrom
405-bug-in-key-of-cosebis

Conversation

@ChaitanyaChawak

@ChaitanyaChawak ChaitanyaChawak commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

🚀 Pull Request Checklist

✅ Summary

Pushed for 'SHE', 'SHE' in the key of COSEBI

🔄 Changes

  • fix in keys of COSEBIs ('SHE', 'SHE')

🛠 How to Test

📝 Documentation

  • This PR updates documentation
  • This PR does not require documentation changes
  • Issue created for documentation update: Don't forget to link the task!

🏗 Related Issues

Resolves #405

📸 Screenshots (if applicable)

📌 Additional Notes


✅ PR Checklist for Developers

  • I have titled this PR before merging as "gh-#:", where "#" represents the task it closes
  • I have run locally pre-commit using pre-commit run --all-files
  • I have tested my changes locally
  • No new warnings or errors introduced
  • I have updated documentation (if applicable)
  • My changes do not introduce breaking changes (i.e: the package still gets installed)
  • I have added unit tests (if applicable)
  • I have consistently updated the GitHub information for the project, including milestones, task types, and other relevant details.

✅ PR Checklist for Reviewers

  • The next PR targets the correct branch
  • CI tests have run and passed for the latest commit on the source branch
  • Check that the code can still be installed if new packages are imported
  • If necessary, the notebooks in the playground will be updated in a corresponding follow-up PR
  • Coverage percentage is retained or increased
  • Quality of new/changed code is acceptable
  • Quality of new/changed unit tests is acceptable
  • No data files have been included in the commits
  • Implementation follows the agreed task description point by point
  • Check that any added folder/file has been added to the README.md file
  • Check that the documentation has been updated accordantly
  • Check that the corresponding branch has been deleted after merging. If not, delete it

@ChaitanyaChawak ChaitanyaChawak linked an issue Jan 28, 2026 that may be closed by this pull request
@ChaitanyaChawak ChaitanyaChawak changed the title fix COSEBIs key bug gh-405: fix COSEBIs key bug Jan 28, 2026
@gcanasherrera

Copy link
Copy Markdown
Member

@all-contributors please add @ChaitanyaChawak for code, bug

@allcontributors

Copy link
Copy Markdown
Contributor

@gcanasherrera

I've put up a pull request to add @ChaitanyaChawak! 🎉

@gcanasherrera gcanasherrera added the bug Something isn't working label Jan 28, 2026
@gcanasherrera gcanasherrera added this to the v0.9.2 milestone Jan 28, 2026
@gcanasherrera gcanasherrera merged commit 220dbfa into main Jan 28, 2026
7 checks passed
@gcanasherrera gcanasherrera deleted the 405-bug-in-key-of-cosebis branch January 28, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in key of COSEBIs

2 participants