Skip to content

gh-414: Fixing redshift variable used when computing growth factor in IA window#421

Merged
gcanasherrera merged 1 commit into
mainfrom
414-fix_z_variable_IA_window
Feb 4, 2026
Merged

gh-414: Fixing redshift variable used when computing growth factor in IA window#421
gcanasherrera merged 1 commit into
mainfrom
414-fix_z_variable_IA_window

Conversation

@raphkou

@raphkou raphkou commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Pull Request Checklist

✅ Summary

This PR fixes the redshift variable being used when computing the growth factor in the IA window function, as discussed in issue #414.

🏗 Related Issues

Resolves #414

✅ PR Checklist for Developers

  • I have titled this PR before merging as "gh-#:", where "#" represents the task it closes
  • I have run locally pre-commit using pre-commit run --all-files
  • I have tested my changes locally
  • No new warnings or errors introduced
  • I have updated documentation (if applicable)
  • My changes do not introduce breaking changes (i.e: the package still gets installed)
  • I have added unit tests (if applicable)
  • I have consistently updated the GitHub information for the project, including milestones, task types, and other relevant details.

✅ PR Checklist for Reviewers

  • The next PR targets the correct branch
  • CI tests have run and passed for the latest commit on the source branch
  • Check that the code can still be installed if new packages are imported
  • If necessary, the notebooks in the playground will be updated in a corresponding follow-up PR
  • Coverage percentage is retained or increased
  • Quality of new/changed code is acceptable
  • Quality of new/changed unit tests is acceptable
  • No data files have been included in the commits
  • Implementation follows the agreed task description point by point
  • Check that any added folder/file has been added to the README.md file
  • Check that the documentation has been updated accordantly
  • Check that the corresponding branch has been deleted after merging. If not, delete it

@raphkou raphkou requested a review from gcanasherrera February 2, 2026 11:56
@gcanasherrera

Copy link
Copy Markdown
Member

It looks neat @raphkou, thanks a lot! Do you mind running the photo.ipynb notebook in playground to make sure everything is in place still? Thanks!

@raphkou

raphkou commented Feb 4, 2026

Copy link
Copy Markdown
Contributor Author

Hello @gcanasherrera, I just did and it runs fine!

@gcanasherrera

Copy link
Copy Markdown
Member

Really, thanks about this and the prompt answer!

@gcanasherrera gcanasherrera added the bug Something isn't working label Feb 4, 2026
@gcanasherrera gcanasherrera added this to the v0.9.2 milestone Feb 4, 2026
@gcanasherrera gcanasherrera merged commit 83a5c78 into main Feb 4, 2026
7 checks passed
@gcanasherrera gcanasherrera deleted the 414-fix_z_variable_IA_window branch February 4, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible wrong redshift variable being used in get_window_IA

2 participants