Skip to content

gh-205: Change CAMB dark energy model from default fluid to ppf#206

Merged
itutusaus merged 1 commit into
mainfrom
gh-205-fluid-to-ppf
Jun 13, 2025
Merged

gh-205: Change CAMB dark energy model from default fluid to ppf#206
itutusaus merged 1 commit into
mainfrom
gh-205-fluid-to-ppf

Conversation

@PedroCarrilho

@PedroCarrilho PedroCarrilho commented Jun 13, 2025

Copy link
Copy Markdown
Member

🚀 Pull Request Checklist

✅ Summary

Change the dark energy model from fluid to ppf in CAMB

🔄 Changes

  • add the argument dark_energy_model='ppf' to .set_dark_energy in camb_cosmology.py

🛠 How to Test

Run cloelib with values of w0 and wa that result in phantom crossing and it works.

📝 Documentation

  • This PR updates documentation
  • This PR does not require documentation changes
  • Issue created for documentation update: Don't forget to link the task!

🏗 Related Issues

Resolves issue #205


✅ PR Checklist for Developers

  • I have titled this PR before merging as "gh-#:", where "#" represents the task it closes
  • My code follows the repository's coding style
  • I have tested my changes locally
  • No new warnings or errors introduced
  • I have updated documentation (if applicable)
  • My changes do not introduce breaking changes
  • I have added tests (if applicable)
  • I have consistently updated the GitHub information for the project, including milestones, task types, and other relevant details.

✅ PR Checklist for Reviewers

  • The next PR targets the correct branch
  • CI tests have run and passed for the latest commit on the source branch
  • Check that the code can still be installed if new packages are imported
  • If necessary, the notebooks in the playground will be updated in a corresponding follow-up PR
  • Coverage percentage is retained or increased
  • Quality of new/changed code is acceptable
  • Quality of new/changed unit tests is acceptable
  • No data files have been included in the commits
  • Implementation follows the agreed task description point by point
  • Check that there are no No newline at the end of file warnings
  • Check that any added folder/file has been added to the README.md file
  • Check that the implementation follows the contributing guidelines and style choices
  • Check that the documentation has been updated accordantly
  • Check that the corresponding branch has been deleted after merging. If not, delete it

@PedroCarrilho PedroCarrilho requested a review from itutusaus June 13, 2025 10:42
@PedroCarrilho PedroCarrilho self-assigned this Jun 13, 2025
@itutusaus

Copy link
Copy Markdown
Member

Thanks @PedroCarrilho! Everything looks good. Merging now

@itutusaus itutusaus merged commit 54d8b2c into main Jun 13, 2025
2 checks passed
@itutusaus itutusaus deleted the gh-205-fluid-to-ppf branch June 13, 2025 10:45
santiagocasas pushed a commit that referenced this pull request Jul 7, 2025
gh-205: Change CAMB dark energy model from default fluid to ppf
didamarkovic pushed a commit that referenced this pull request Jul 10, 2025
gh-205: Change CAMB dark energy model from default fluid to ppf
chiaramoretti pushed a commit that referenced this pull request Aug 1, 2025
gh-205: Change CAMB dark energy model from default fluid to ppf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants