Skip to content

gh-298: added .prettierignore#299

Merged
marcobonici merged 1 commit into
mainfrom
298-add-prettierignore
Oct 21, 2025
Merged

gh-298: added .prettierignore#299
marcobonici merged 1 commit into
mainfrom
298-add-prettierignore

Conversation

@gcanasherrera

@gcanasherrera gcanasherrera commented Oct 17, 2025

Copy link
Copy Markdown
Member

🚀 Pull Request Checklist

✅ Summary

This PR adds .allcontributors_ to the .prettierignore file, ensuring Prettier does not attempt to format it. This prevents unnecessary formatting changes in the contributors file.

🔄 Changes

  • Added .allcontributors to .prettierignore
  • Verified Prettier skips the file when running prettier --check .
  • No other files were modified

🛠 How to Test

  1. Ensure .prettierignore exists at the root of the repository.

  2. Confirm that .allcontributors is skipped and no formatting changes are suggested for it.

📝 Documentation

  • This PR updates documentation
  • This PR does not require documentation changes

🏗 Related Issues

Resolves #298

📸 Screenshots (if applicable)

N/A

📌 Additional Notes

No additional notes.

✅ PR Checklist for Developers

  • I have titled this PR before merging as "gh-#:", where "#" represents the task it closes
  • I have run locally pre-commit using pre-commit run --all-files
  • I have tested my changes locally
  • No new warnings or errors introduced
  • I have updated documentation (if applicable)
  • My changes do not introduce breaking changes (i.e: the package still gets installed)
  • I have added unit tests (if applicable)
  • I have consistently updated the GitHub information for the project, including milestones, task types, and other relevant details.

✅ PR Checklist for Reviewers

  • The next PR targets the correct branch
  • CI tests have run and passed for the latest commit on the source branch
  • Check that the code can still be installed if new packages are imported
  • If necessary, the notebooks in the playground will be updated in a corresponding follow-up PR
  • Coverage percentage is retained or increased
  • Quality of new/changed code is acceptable
  • Quality of new/changed unit tests is acceptable
  • No data files have been included in the commits
  • Implementation follows the agreed task description point by point
  • Check that there are no No newline at the end of file warnings
  • Check that any added folder/file has been added to the README.md file
  • Check that the implementation follows the contributing guidelines and style choices
  • Check that the documentation has been updated accordantly
  • Check that the corresponding branch has been deleted after merging. If not, delete it

@gcanasherrera gcanasherrera linked an issue Oct 17, 2025 that may be closed by this pull request
@gcanasherrera gcanasherrera changed the title added .prettierignore gh-298: added .prettierignore Oct 17, 2025
@gcanasherrera gcanasherrera changed the title gh-298: added .prettierignore #gh-298: added .prettierignore Oct 17, 2025
@gcanasherrera gcanasherrera changed the title #gh-298: added .prettierignore gh-298: added .prettierignore Oct 17, 2025
@gcanasherrera gcanasherrera self-assigned this Oct 17, 2025
@gcanasherrera gcanasherrera added the bug Something isn't working label Oct 17, 2025
@gcanasherrera gcanasherrera added this to the v0.9.1 milestone Oct 17, 2025
@gcanasherrera

Copy link
Copy Markdown
Member Author

@marcobonici make me the favor...

it's just stupid

@marcobonici marcobonici left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@marcobonici marcobonici merged commit 909bc99 into main Oct 21, 2025
6 checks passed
@marcobonici marcobonici deleted the 298-add-prettierignore branch October 21, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working coordination

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add .prettierignore

2 participants