Skip to content

gh-393: missing-observational-systematics-on-individual-loop-terms-of-gcspectro#394

Merged
chiaramoretti merged 4 commits into
mainfrom
393-missing-observational-systematics-on-individual-loop-terms-of-gcspectro
Jan 23, 2026
Merged

gh-393: missing-observational-systematics-on-individual-loop-terms-of-gcspectro#394
chiaramoretti merged 4 commits into
mainfrom
393-missing-observational-systematics-on-individual-loop-terms-of-gcspectro

Conversation

@AndreaPezzotta

@AndreaPezzotta AndreaPezzotta commented Jan 22, 2026

Copy link
Copy Markdown
Member

🚀 Pull Request Checklist

✅ Summary

This PR solves the bug described in #393

🔄 Changes

  • Added function _PK2d_term to legendre multipoles class, which is in charge of retrieving the 2d spectrum from the specified non-linear code and add the effect from observational systematics
  • Substituted call to 2d method of the non-linear code with the function from the previous item

📝 Documentation

  • This PR updates documentation
  • This PR does not require documentation changes
  • Issue created for documentation update: Don't forget to link the task!

🏗 Related Issues

Resolves #393

📸 Screenshots (if applicable)

Now cases 2 and 3 shown in the task description of #393 are fixed:

Screenshot 2026-01-22 at 10 39 56
Screenshot 2026-01-22 at 10 40 35

✅ PR Checklist for Developers

  • I have titled this PR before merging as "gh-#:", where "#" represents the task it closes
  • I have run locally pre-commit using pre-commit run --all-files
  • I have tested my changes locally
  • No new warnings or errors introduced
  • I have updated documentation (if applicable)
  • My changes do not introduce breaking changes (i.e: the package still gets installed)
  • I have added unit tests (if applicable)
  • I have consistently updated the GitHub information for the project, including milestones, task types, and other relevant details.

✅ PR Checklist for Reviewers

  • The next PR targets the correct branch
  • CI tests have run and passed for the latest commit on the source branch
  • Check that the code can still be installed if new packages are imported
  • If necessary, the notebooks in the playground will be updated in a corresponding follow-up PR
  • Coverage percentage is retained or increased
  • Quality of new/changed code is acceptable
  • Quality of new/changed unit tests is acceptable
  • No data files have been included in the commits
  • Implementation follows the agreed task description point by point
  • Check that any added folder/file has been added to the README.md file
  • Check that the documentation has been updated accordantly
  • Check that the corresponding branch has been deleted after merging. If not, delete it

…th the inclusion of observational systematics, and called this function inside power_term_multipoles
@AndreaPezzotta AndreaPezzotta self-assigned this Jan 22, 2026
@AndreaPezzotta AndreaPezzotta added bug Something isn't working galaxy-clustering Tasks related to the spectroscopic observables labels Jan 22, 2026
@AndreaPezzotta AndreaPezzotta added this to the v0.9.2 milestone Jan 22, 2026

@gcanasherrera gcanasherrera left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny comment, thanks for spotting this out!

Comment thread cloelib/summary_statistics/legendre_multipoles.py Outdated
@gcanasherrera

Copy link
Copy Markdown
Member

@chiaramoretti do you want to have a look at it too?

@chiaramoretti chiaramoretti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@chiaramoretti

Copy link
Copy Markdown
Member

@AndreaPezzotta all good, thanks for spotting the bug! merging

@chiaramoretti chiaramoretti merged commit 4d4ada8 into main Jan 23, 2026
6 checks passed
@chiaramoretti chiaramoretti deleted the 393-missing-observational-systematics-on-individual-loop-terms-of-gcspectro branch January 23, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working galaxy-clustering Tasks related to the spectroscopic observables

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing observational systematics on individual loop terms of GCspectro

3 participants