Skip to content
This repository was archived by the owner on Jun 25, 2020. It is now read-only.

stackdriver-nozzle/tile: debugging options, logging configuration #147

Merged
johnsonj merged 1 commit into from
Nov 9, 2017
Merged

stackdriver-nozzle/tile: debugging options, logging configuration #147

johnsonj merged 1 commit into from
Nov 9, 2017

Conversation

@johnsonj
Copy link
Contributor

@johnsonj johnsonj commented Nov 7, 2017 •
edited
Loading

  • Expose NOZZLE_DEBUG setting to allow for pprof access on the hosted
    nozzle (http://:6060/debug/pprof/). This also enables Stackdriver Error reporting for crashes. Fixes Enable Nozzle Debugging for Tile Users #114
  • Expose Logging buffer duration/size settings and update default to a more reasonable value
  • Add Labels for recently added options in the tile for better presentation. At some point we'll want to separate these settings into logical pages now that the options are getting long.

/cc @knyar @fluffle

This change is Reviewable

@johnsonj johnsonj changed the title stackdriver-nozzle/tike: debugging options, logging configuration stackdriver-nozzle/tile: debugging options, logging configuration Nov 7, 2017
@johnsonj
stackdriver-nozzle/tile: debugging options, logging configuration
8b3f26d 
- Expose NOZZLE_DEBUG setting to allow for pprof access on the hosted
  nozzle (http://<VM>:6060/debug/pprof/). Fixes cloudfoundry-community#114
- Expose Logging buffer duration/size settings and update default to a
  more reasonable value
- Add Labels for recently added options in the tile for better
  presentation. At some point we'll want to separate these settings into
  logical pages now that the options are getting long.
@johnsonj johnsonj force-pushed the pr-nozzle-debug-log-config branch from 59d39df to 8b3f26d Compare November 7, 2017 23:17
@fluffle
Copy link
Collaborator

fluffle commented Nov 9, 2017

:lgtm: ship it \o/

Review status: 0 of 5 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

src/stackdriver-nozzle/app/runner.go, line 28 at r1 (raw file):

		go func() {
			a.logger.Info("pprof", lager.Data{
				"http.ListenAndServe": http.ListenAndServe("0.0.0.0:6060", nil),

This is a really neat way of logging any error that arises :-)

Comments from Reviewable

@johnsonj
Copy link
Contributor Author

johnsonj commented Nov 9, 2017

Thanks!

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@johnsonj johnsonj merged commit b384fbf into cloudfoundry-community:develop Nov 9, 2017
@johnsonj johnsonj mentioned this pull request Nov 20, 2017
Merged
@johnsonj johnsonj mentioned this pull request Feb 20, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnsonj @fluffle