Skip to content

Conversation

@strehle
Copy link
Member

@strehle strehle commented Jan 16, 2025

No description provided.

@duanemay
Copy link
Member

The issue seems to be that when UAA is running on a standard port :80 or :443 and that port is included in the metadata. The destination within the SAML response includes the port, but the location from the relying party registration does not. Therefore the comparison does not match and authentication fails.

@aramprice
Copy link
Member

Agreed that the default port stripping is probably at the root of this.

The purpose behind this change is to expose both of the elements being compared in the conditional so that it is clearer why this particular error is returned by UAA.

Having only half of the information in the error message makes it impossible to understand the root cause when this error occurs.

Copy link
Member

@duanemay duanemay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug info is fine, need to circle back on fix

@strehle strehle merged commit b6ec72f into develop Feb 2, 2025
22 checks passed
@strehle strehle deleted the fix/issue/3226 branch February 2, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

SAML "invalid destination" error message should include location, as well as destination

3 participants