Skip to content

Conversation

@adrianhoelzl-sap
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds proper cleanup of ThreadLocal storage in the ExternalOAuthAuthenticationManager by clearing the origin ThreadLocal after authentication completes.

  • Overrides the authenticate method to ensure ThreadLocal cleanup
  • Adds ThreadLocal.remove() call after successful authentication

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@strehle strehle force-pushed the externaloauthauthenticationmanager-clear-origin-threadlocal-after-authenticate branch from d93519e to 29d9265 Compare September 18, 2025 21:31
@strehle strehle requested a review from Copilot September 18, 2025 21:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-project-automation github-project-automation bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Sep 18, 2025
@strehle strehle merged commit 8011b31 into develop Sep 18, 2025
51 checks passed
@strehle strehle deleted the externaloauthauthenticationmanager-clear-origin-threadlocal-after-authenticate branch September 18, 2025 21:35
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants