-
Notifications
You must be signed in to change notification settings - Fork 840
Clear Origin ThreadLocal after AuthN in ExternalOAuthAuthenticationManager #3619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear Origin ThreadLocal after AuthN in ExternalOAuthAuthenticationManager #3619
Conversation
...in/java/org/cloudfoundry/identity/uaa/provider/oauth/ExternalOAuthAuthenticationManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds proper cleanup of ThreadLocal storage in the ExternalOAuthAuthenticationManager by clearing the origin ThreadLocal after authentication completes.
- Overrides the authenticate method to ensure ThreadLocal cleanup
- Adds ThreadLocal.remove() call after successful authentication
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...in/java/org/cloudfoundry/identity/uaa/provider/oauth/ExternalOAuthAuthenticationManager.java
Outdated
Show resolved
Hide resolved
…adLocal to finally block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
d93519e to
29d9265
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.